xfs
[Top] [All Lists]

Re: [PATCH v6] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate

To: Namjae Jeon <linkinjeon@xxxxxxxxx>
Subject: Re: [PATCH v6] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Sat, 22 Feb 2014 12:09:30 -0500
Cc: viro@xxxxxxxxxxxxxxxxxx, david@xxxxxxxxxxxxx, bpm@xxxxxxx, adilger.kernel@xxxxxxxxx, jack@xxxxxxx, mtk.manpages@xxxxxxxxx, lczerner@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Namjae Jeon <namjae.jeon@xxxxxxxxxxx>, Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=thunk.org; s=mail; t=1393088970; bh=u8BEbWYkYlZXydLxmOqHOO1+Dbzw/jnZoU6IYDfhR5o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q4oHX/+Op9ef0Dtuj9KCtoCNZ7uFUJFvM/jp3ELxL5ZyhrRciut8hA962Kkm/GNh8 b+P0pepDEObwu1WTwsNvXmI4blRAqo4fVzayFP0mtnc21KVKS8z6AiNFjLvyDZQnKc zsFZNmgM8l86Skwb+Byi5VeOEer60u+vP/XQJrIc=
In-reply-to: <1392908861-3563-1-git-send-email-linkinjeon@xxxxxxxxx>
Mail-followup-to: Theodore Ts'o <tytso@xxxxxxx>, Namjae Jeon <linkinjeon@xxxxxxxxx>, viro@xxxxxxxxxxxxxxxxxx, david@xxxxxxxxxxxxx, bpm@xxxxxxx, adilger.kernel@xxxxxxxxx, jack@xxxxxxx, mtk.manpages@xxxxxxxxx, lczerner@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Namjae Jeon <namjae.jeon@xxxxxxxxxxx>, Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
References: <1392908861-3563-1-git-send-email-linkinjeon@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Feb 21, 2014 at 12:07:41AM +0900, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
> 
> This patch implements fallocate's FALLOC_FL_COLLAPSE_RANGE for Ext4.
> 
> The semantics of this flag are following:
> 1) It collapses the range lying between offset and length by removing any data
>    blocks which are present in this range and than updates all the logical
>    offsets of extents beyond "offset + len" to nullify the hole created by
>    removing blocks. In short, it does not leave a hole.
> 2) It should be used exclusively. No other fallocate flag in combination.
> 3) Offset and length supplied to fallocate should be fs block size aligned
>    in case of xfs and ext4.
> 4) Collaspe range does not work beyond i_size.
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
> Signed-off-by: Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
> Tested-by: Dongsu Park <dongsu.park@xxxxxxxxxxxxxxxx>

In terms of how to get this upstream, it looks like if we do something
like this, we can let this patch go via the ext4 tree and we don't
need to worry about whether the vfs level changes have gone in our
not.

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index ad13359..d7a78ed 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -46,6 +46,10 @@
 
 #include <trace/events/ext4.h>
 
+#ifndef FALLOC_FL_COLLAPSE_RANGE
+#define FALLOC_FL_COLLAPSE_RANGE       0x08
+#endif
+
 /*
  * used by extent splitting.
  */


> +     ret = ext4_es_remove_extent(inode, punch_start,
> +                                 EXT_MAX_BLOCKS - punch_start - 1);
> +     if (ret) {
> +             up_write(&EXT4_I(inode)->i_data_sem);
> +             goto out_stop;
> +     }

Doing this at first is probably a bad idea; you should do this at the
end, and then completely invalidate the es cache for that inode.  That
way, the right thing happens if you get an error in the middle
releasing the boxes and shifting the extents:

> +
> +     ret = ext4_ext_remove_space(inode, punch_start, punch_stop - 1);
> +     if (ret) {
> +             up_write(&EXT4_I(inode)->i_data_sem);
> +             goto out_stop;
> +     }
> +
> +     ret = ext4_ext_shift_extents(inode, handle, punch_stop,
> +                                  punch_stop - punch_start);
> +     if (ret) {
> +             up_write(&EXT4_I(inode)->i_data_sem);
> +             goto out_stop;
> +     }

The fact that you are doing these two as two separate steps is
dangerous; what if you've already released the blocks in
ext4_ext_remove_space(), and ext4_ext_shift_extents() fails in the
middle of the processing?  That will leave the file system
inconsistent, which would be bad.

Making sure that the right happens if there is a failure in the middle
of the operation is Really Important....

                                        - Ted

<Prev in Thread] Current Thread [Next in Thread>