[Top] [All Lists]

Re: [PATCH 1/3] xfs: always do log forces via the workqueue

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH 1/3] xfs: always do log forces via the workqueue
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 21 Feb 2014 11:02:57 +1100
Cc: Brian Foster <bfoster@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5306833D.7080600@xxxxxxx>
References: <1392783402-4726-1-git-send-email-david@xxxxxxxxxxxxx> <1392783402-4726-2-git-send-email-david@xxxxxxxxxxxxx> <5304F6F6.3070007@xxxxxxxxxx> <20140220002358.GH4916@dastard> <5306168B.8080209@xxxxxxx> <20140220220747.GQ4916@dastard> <5306833D.7080600@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Feb 20, 2014 at 04:35:41PM -0600, Mark Tinguely wrote:
> On 02/20/14 16:07, Dave Chinner wrote:
> >On Thu, Feb 20, 2014 at 08:51:55AM -0600, Mark Tinguely wrote:
> >>We know the later error paths in xfs_cil_push() will not do a wake,
> >>now is a good time to fix that.
> >
> >I'm not sure what you are talking about here. If there's a problem,
> >please send patches.
> http://oss.sgi.com/archives/xfs/2013-12/msg00870.html

Which resulted in a discussion and discovery of more problems
that also needed fixing, so I'm waiting for patches to be posted
that fix them.

You know what the problems are, you know how they should be fixed
(it's in the discussion thread), and you are capable of writing
the fixes and testing them. So, please send patches.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>