xfs
[Top] [All Lists]

Re: [PATCH] xfs_repair: fix sibling pointer tests in verify_dir2_path()

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_repair: fix sibling pointer tests in verify_dir2_path()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 20 Feb 2014 07:41:22 -0800
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <53051DB5.4080403@xxxxxxxxxx>
References: <53051DB5.4080403@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Feb 19, 2014 at 03:10:13PM -0600, Eric Sandeen wrote:
> RH QE reported that if we create a 1G filesystem with default
> options, mount it, and create inodes until full, then run
> repair, repair reports corruption in verify_dir2_path() with:
> 
> > bad back pointer in block 8390324 for directory inode 131

Can you please wire this up for xfstests?

> 
> The commit 88b32f0 xfs: add CRCs to dir2/da node blocks
> had a small error which regressed this; although we switch
> to the "newnode," to check sibling pointers, we re-populate
> the node hdr with the old "node" data.  This causes the
> backpointer test to be testing the wrong node's values.
> 
> Fixing this bug fixes the testcase.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>