xfs
[Top] [All Lists]

Re: [PATCH v5 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallo

To: Dongsu Park <dongsu.park@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v5 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate
From: Namjae Jeon <linkinjeon@xxxxxxxxx>
Date: Thu, 20 Feb 2014 07:56:21 +0900
Cc: viro@xxxxxxxxxxxxxxxxxx, david@xxxxxxxxxxxxx, bpm@xxxxxxx, tytso@xxxxxxx, adilger.kernel@xxxxxxxxx, jack@xxxxxxx, mtk.manpages@xxxxxxxxx, lczerner@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Namjae Jeon <namjae.jeon@xxxxxxxxxxx>, Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=UiMGX4/dT9xp/H16Cu2+rnu2Gn/nA32XO7TAI7LDukc=; b=Kz8tyzmF5vw9InGqASryLq8WK2PjKTRBsWFiPCZ9+Hh8pMxiIbkTHPwxbHUmC+/x6C FdPEVvRAJqwGTZVTyU33NLYj8SdeUV+Im+3VMATGd78htRWm2R9pRUOliYj/aeBxoCzS mcLgUF0v7Yg5lXS6uBSKVrhV40f5WHMVd9anRk5qWHELU7Q1rEONytCCfnRap4qaz6ds cxzXwKbALMb+nZPJAVAwpbTPQ3aF4mJrSTx1XiesoogzBUw/HDo/b2NiyGC5caL9zBlq VHkbxOrjzhDlxuildoHvLv65LkWE+huESK2NUnL4HBOSuNAMiFAgLwjrvlahfFDkkZb5 Y8Pg==
In-reply-to: <20140219215805.GA1714@xxxxxxxxx>
References: <1392741489-20097-1-git-send-email-linkinjeon@xxxxxxxxx> <20140219215805.GA1714@xxxxxxxxx>
2014-02-20 6:58 GMT+09:00, Dongsu Park <dongsu.park@xxxxxxxxxxxxxxxx>:
> Hi Namjae,
> see below:
Hi Dongsu.
>
> On 19.02.2014 01:38, Namjae Jeon wrote:
>> This patch implements fallocate's FALLOC_FL_COLLAPSE_RANGE for Ext4.
> ...<snip>...
>> +    /*
>> +     * Don't start shifting extents until we make sure the hole is big
>> +     * enough to accomodate the shift.
>> +     */
>> +    path = ext4_ext_find_extent(inode, start - 1, NULL, 0);
>> +    depth = path->p_depth;
>> +    extent =  path[depth].p_ext;
>> +    ex_start = extent->ee_block;
>> +    ex_end = extent->ee_block + ext4_ext_get_actual_len(extent);
>> +    ext4_ext_drop_refs(path);
>> +    kfree(path);
>> +
>> +    if ((start == ex_start && shift > ex_start) ||
>> +        (shift > start - ex_end)) {
>
> This line causes a compile error. So the fix would be like that:
Oops.. I made a stupid mistake when creating the patch at dawn..
Thanks for your pointing.
>
> -         (shift > start - ex_end)) {
> +         (shift > start - ex_end))
>
>> +            return -EINVAL;
>> +
>> +    /* Its safe to start updating extents */
Yes, Right.
> ...<snip>...
>
> Apart from that, the whole patchset seems to work without error,
> both on xfs and on ext4.
> Of course I had to remove Lukas' patches before testing collapse-range.
> So it would be excellent if two patch series could get somehow merged.
>
> Tested-by: Dongsu Park <dongsu.park@xxxxxxxxxxxxxxxx>
Thank you so much for your testing!
>
> Regards,
> Dongsu
>

<Prev in Thread] Current Thread [Next in Thread>