xfs
[Top] [All Lists]

Re: [PATCH 8/9] xfs: print useful caller information in xfs_error_report

To: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 8/9] xfs: print useful caller information in xfs_error_report
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Wed, 19 Feb 2014 20:42:37 +0800
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1392767549-25574-9-git-send-email-sandeen@xxxxxxxxxx>
References: <1392767549-25574-1-git-send-email-sandeen@xxxxxxxxxx> <1392767549-25574-9-git-send-email-sandeen@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 02/19 2014 07:52 AM, Eric Sandeen wrote:
> xfs_error_report used to just print the hex address of the caller;
> %pF will give us something more human-readable.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_error.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c
> index 8733c59..04d8e65 100644
> --- a/fs/xfs/xfs_error.c
> +++ b/fs/xfs/xfs_error.c
> @@ -156,7 +156,7 @@ xfs_error_report(
>  {
>       if (level <= xfs_error_level) {
>               xfs_alert_tag(mp, XFS_PTAG_ERROR_REPORT,
> -             "Internal error %s at line %d of file %s.  Caller 0x%p",
> +             "Internal error %s at line %d of file %s.  Caller %pF",
>                           tag, linenum, filename, ra);
>  
>               xfs_stack_trace();

Reviewed-by: Jie Liu <jeff.liu@xxxxxxxxxx>

In comparison with the hex code, this is obviously more readable as below.

Patched:
-------
XFS (sda7): Internal error xfs_sb_read_verify at line 630 of file 
fs/xfs/xfs_sb.c.  Caller xfs_buf_iodone_work+0xa5/0xd0 [xfs]
<snip>
Call Trace:
[<ffffffff81741f15>] dump_stack+0x45/0x56
[<ffffffffa07a5a0b>] xfs_error_report+0x3b/0x40 [xfs]
[<ffffffffa07a26b5>] ? xfs_buf_iodone_work+0xa5/0xd0 [xfs]
[<ffffffffa07a5a65>] xfs_corruption_error+0x55/0x80 [xfs]
[<ffffffffa080bf23>] xfs_sb_read_verify+0x143/0x150 [xfs]
[<ffffffffa07a26b5>] ? xfs_buf_iodone_work+0xa5/0xd0 [xfs]
[<ffffffff8108744f>] ? process_one_work+0x1af/0x540
[<ffffffffa07a26b5>] xfs_buf_iodone_work+0xa5/0xd0 [xfs]
<snip>


Old:
----
[  235.506754] XFS (sda7): Internal error xfs_sb_read_verify at line 630 of 
file fs/xfs/xfs_sb.c.  Caller 0xffffffffa08aa6b5
<snip>
[  235.506796] Call Trace:
[  235.506802]  [<ffffffff81741f15>] dump_stack+0x45/0x56
[  235.506818]  [<ffffffffa08ada0b>] xfs_error_report+0x3b/0x40 [xfs]
[  235.506832]  [<ffffffffa08aa6b5>] ? xfs_buf_iodone_work+0xa5/0xd0 [xfs]
[  235.506845]  [<ffffffffa08ada65>] xfs_corruption_error+0x55/0x80 [xfs]
[  235.506871]  [<ffffffffa0913f23>] xfs_sb_read_verify+0x143/0x150 [xfs]
[  235.506885]  [<ffffffffa08aa6b5>] ? xfs_buf_iodone_work+0xa5/0xd0 [xfs]
[  235.506890]  [<ffffffff8108744f>] ? process_one_work+0x1af/0x540
[  235.506903]  [<ffffffffa08aa6b5>] xfs_buf_iodone_work+0xa5/0xd0 [xfs]
<snip>


Thanks,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>