xfs
[Top] [All Lists]

Re: [PATCH 3/9] xfs: skip pointless CRC updates after verifier failures

To: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 3/9] xfs: skip pointless CRC updates after verifier failures
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Wed, 19 Feb 2014 14:35:50 +0800
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1392767549-25574-4-git-send-email-sandeen@xxxxxxxxxx>
References: <1392767549-25574-1-git-send-email-sandeen@xxxxxxxxxx> <1392767549-25574-4-git-send-email-sandeen@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 02/19 2014 07:52 AM, Eric Sandeen wrote:
> Most write verifiers don't update CRCs after the verifier
> has failed and the buffer has been marked in error.  These
> two didn't, but should.
> 
> Add returns to the verifier failure block,
> since the buffer won't be written anyway.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_alloc_btree.c  |    1 +
>  fs/xfs/xfs_ialloc_btree.c |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/xfs/xfs_alloc_btree.c b/fs/xfs/xfs_alloc_btree.c
> index 1308542..144d3b0 100644
> --- a/fs/xfs/xfs_alloc_btree.c
> +++ b/fs/xfs/xfs_alloc_btree.c
> @@ -373,6 +373,7 @@ xfs_allocbt_write_verify(
>               XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW,
>                                    bp->b_target->bt_mount, bp->b_addr);
>               xfs_buf_ioerror(bp, EFSCORRUPTED);
> +             return;
>       }
>       xfs_btree_sblock_calc_crc(bp);
>  
> diff --git a/fs/xfs/xfs_ialloc_btree.c b/fs/xfs/xfs_ialloc_btree.c
> index c8fa5bb..0028c50 100644
> --- a/fs/xfs/xfs_ialloc_btree.c
> +++ b/fs/xfs/xfs_ialloc_btree.c
> @@ -261,6 +261,7 @@ xfs_inobt_write_verify(
>               XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW,
>                                    bp->b_target->bt_mount, bp->b_addr);
>               xfs_buf_ioerror(bp, EFSCORRUPTED);
> +             return;
>       }
>       xfs_btree_sblock_calc_crc(bp);

Looks good to me.

Reviewed-by: Jie Liu <jeff.liu@xxxxxxxxxx>


Thanks,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>