| To: | "Theodore Ts'o" <tytso@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate |
| From: | Namjae Jeon <linkinjeon@xxxxxxxxx> |
| Date: | Wed, 19 Feb 2014 10:08:39 +0900 |
| Cc: | Namjae Jeon <linkinjeon@xxxxxxxxx>, LukÃÅ Czerner <lczerner@xxxxxxxxxx>, viro@xxxxxxxxxxxxxxxxxx, david@xxxxxxxxxxxxx, bpm@xxxxxxx, adilger.kernel@xxxxxxxxx, jack@xxxxxxx, mtk.manpages@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Namjae Jeon <namjae.jeon@xxxxxxxxxxx>, Ashish Sangwan <a.sangwan@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=rwpqu5n8wpBOzrjFvlrQS1Wk7ushMmlxpNSUWyRzkwQ=; b=0mr4DmqpOqKsG2LsLTQ5jmspxTmM1184RUjd2paXJQnNE3qw4URE7J2gK7EDW+12Rg xl/gMQ5bwqtZdYMpL0OFz52afv/2gI40d5mYzFwUzC7a0jwGYj0BE3P55FLYpDHUONAl npD7/kjvSe0NF82yqA7NCZyZjFFBHbaDxk7/5cwiRelcVJYO9aaISgF8yIfpZVhR6vkv gD43id5dMJ/ycoIF5gQ6uY9xolyPtNjA7w1V6cgk12Q1+wXSEJC5e4VRa3UGX0c4/j45 z0CR0fIM+nBOfsstIhC8akxBymWWB6C+in1OvWsW5o86825df9cTMBkOEwzA7f0NclV/ 1QCQ== |
| In-reply-to: | <20140218143005.GO26580@xxxxxxxxx> |
| References: | <1391319874-3203-1-git-send-email-linkinjeon@xxxxxxxxx> <alpine.LFD.2.00.1402111209450.2225@xxxxxxxxxxxxxxxxxxxxx> <CAKYAXd-bD6ZZgpc9E8V1kD9Dj2wrCkbi1i6drNBdUAwsMiv5gg@xxxxxxxxxxxxxx> <alpine.LFD.2.00.1402181001530.2216@xxxxxxxxxxxxxxxxxxxxx> <CAKYAXd_xpWg-=T_1PghL_u9wDKTX_Ey5mJxbgVVKth8NoexQQg@xxxxxxxxxxxxxx> <20140218143005.GO26580@xxxxxxxxx> |
2014-02-18 23:30 GMT+09:00, Theodore Ts'o <tytso@xxxxxxx>: > Namjae, Hi Ted. > > Did you respond to Matthew Wilcox's comments/question from Feb. 2nd? Sorry, I didn't catch about this. I just replied from Matthew's mail. Thanks for your remind. > >> > What if the file is mmaped at the time somebody issues this command? >> > Seems to me we should drop pagecache pages that overlap with the >> > removed blocks. If the removed range is not a multiple of PAGE_SIZE, >> > then we should also drop any pagecache pages after the removed range. >> >> Oops, forgot to add "and if it is a multiple of page size, then we need >> to update the offsets of any pages after the removed page". > > Dave responded that XFS does the right thing when doing a punch hole > operation, but it wasn't obvious to me whether FL_COLLAPSE_RANGE does > the right thing with ext4. > > Thanks, > > - Ted > |
| Previous by Date: | [ANNOUNCE] xfsprogs: master branch updated to e13d0f7, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 1/9] xfs: skip verification on initial "guess" superblock read, Dave Chinner |
| Previous by Thread: | Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate, Theodore Ts'o |
| Next by Thread: | [PATCH] util-linux/fallocate: introduce an option -c to support FALLOC_FL_COLLAPSE_RANGE, Dongsu Park |
| Indexes: | [Date] [Thread] [Top] [All Lists] |