xfs
[Top] [All Lists]

Re: [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode

To: Shaun Gosse <sgosse@xxxxxxx>
Subject: Re: [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 19 Feb 2014 11:13:07 +1100
Cc: Zachary Kotlarek <zach@xxxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <8D3FA7645C1CFC4E9E783D22B4C708644AA855@xxxxxxxxxxxxxxxxxxxxxxxxx>
References: <1389806582-26815-1-git-send-email-zach@xxxxxxxxxxxx> <1389806582-26815-2-git-send-email-zach@xxxxxxxxxxxx> <8D3FA7645C1CFC4E9E783D22B4C708644AA855@xxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jan 15, 2014 at 05:31:34PM +0000, Shaun Gosse wrote:
> Looks good.
> 
> Reviewed-by: Shaun Gosse <sgosse@xxxxxxx>
> 
> Thanks again,
> -Shaun
> 
> -----Original Message-----
> From: xfs-bounces@xxxxxxxxxxx [mailto:xfs-bounces@xxxxxxxxxxx] On Behalf Of 
> Zachary Kotlarek
> Sent: Wednesday, January 15, 2014 11:23 AM
> To: xfs@xxxxxxxxxxx
> Cc: Zachary Kotlarek
> Subject: [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode
> 
> ---
>  man/man8/mkfs.xfs.8 |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8 index 8184e10..e1c5cf7 
> 100644
> --- a/man/man8/mkfs.xfs.8
> +++ b/man/man8/mkfs.xfs.8
> @@ -513,9 +513,11 @@ any power of 2 size from the filesystem block size up to 
> 65536.
>  .IP
>  The
>  .B version=ci
> -option enables ASCII only case-insensitive filename lookup and version
> +option enables ASCII-only case-insensitive filename lookup and version
>  2 directories. Filenames are case-preserving, that is, the names -are stored 
> in directories using the case they were created with.
> +are stored in directories using the case they were created with. In 
> +this mode non-ASCII file and directory names are not supported and are 
> +likely to become inaccessible if used.
>  .IP
>  Note: Version 1 directories are not supported.
>  .TP
> --

I missed this when it was posted and only just caught it. Sorry
about that.

I can't commit it without a Signed-off-by. Zachary, can you resned
this with a commit message indicating why the documentation change
is necessary and with a proper SOB on it?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] Add a warning about non-ASCII filenames in ASCII-CI mode, Dave Chinner <=