xfs
[Top] [All Lists]

Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for f

To: Namjae Jeon <linkinjeon@xxxxxxxxx>
Subject: Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Tue, 18 Feb 2014 09:30:05 -0500
Cc: LukÃÅ Czerner <lczerner@xxxxxxxxxx>, viro@xxxxxxxxxxxxxxxxxx, david@xxxxxxxxxxxxx, bpm@xxxxxxx, adilger.kernel@xxxxxxxxx, jack@xxxxxxx, mtk.manpages@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Namjae Jeon <namjae.jeon@xxxxxxxxxxx>, Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=thunk.org; s=mail; t=1392733806; bh=+Xmp3oQn0M6+O0kCAY4trhutKLE1Z3umZFga9p9AU1o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qAmgnFlB6zLYwlERRUzTXv+2EowePHkTH6IbN66rYYLJlXI5nN+uW8J8C5vYjRytl 3bDDXfXgIdnecOi/RD16Wy7Ksopchw6Y4W6SXPdldRdZkXI7LsgTinLFjtETIGVoOX C3seITz5rrfpmVnKISshyQR09Pdn+ujb8lTofqiw=
In-reply-to: <CAKYAXd_xpWg-=T_1PghL_u9wDKTX_Ey5mJxbgVVKth8NoexQQg@xxxxxxxxxxxxxx>
Mail-followup-to: Theodore Ts'o <tytso@xxxxxxx>, Namjae Jeon <linkinjeon@xxxxxxxxx>, LukÃÅ Czerner <lczerner@xxxxxxxxxx>, viro@xxxxxxxxxxxxxxxxxx, david@xxxxxxxxxxxxx, bpm@xxxxxxx, adilger.kernel@xxxxxxxxx, jack@xxxxxxx, mtk.manpages@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Namjae Jeon <namjae.jeon@xxxxxxxxxxx>, Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
References: <1391319874-3203-1-git-send-email-linkinjeon@xxxxxxxxx> <alpine.LFD.2.00.1402111209450.2225@xxxxxxxxxxxxxxxxxxxxx> <CAKYAXd-bD6ZZgpc9E8V1kD9Dj2wrCkbi1i6drNBdUAwsMiv5gg@xxxxxxxxxxxxxx> <alpine.LFD.2.00.1402181001530.2216@xxxxxxxxxxxxxxxxxxxxx> <CAKYAXd_xpWg-=T_1PghL_u9wDKTX_Ey5mJxbgVVKth8NoexQQg@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
Namjae,

Did you respond to Matthew Wilcox's comments/question from Feb. 2nd?

> > What if the file is mmaped at the time somebody issues this command?
> > Seems to me we should drop pagecache pages that overlap with the
> > removed blocks.  If the removed range is not a multiple of PAGE_SIZE,
> > then we should also drop any pagecache pages after the removed range.
>
> Oops, forgot to add "and if it is a multiple of page size, then we need
> to update the offsets of any pages after the removed page".

Dave responded that XFS does the right thing when doing a punch hole
operation, but it wasn't obvious to me whether FL_COLLAPSE_RANGE does
the right thing with ext4.

Thanks,

                                        - Ted

<Prev in Thread] Current Thread [Next in Thread>