xfs
[Top] [All Lists]

Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for f

To: LukÃÅ Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate
From: Namjae Jeon <linkinjeon@xxxxxxxxx>
Date: Tue, 18 Feb 2014 18:50:54 +0900
Cc: viro@xxxxxxxxxxxxxxxxxx, david@xxxxxxxxxxxxx, bpm@xxxxxxx, tytso@xxxxxxx, adilger.kernel@xxxxxxxxx, jack@xxxxxxx, mtk.manpages@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Namjae Jeon <namjae.jeon@xxxxxxxxxxx>, Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=r3ntOMuNFB4iJNiPS7efVpKzhAp5BrmVEkhw3q7dnDE=; b=f2v6fDCP7o64o/kddL4eWqzk7fyuBeCkvD9zilAFRiWvLwXnsUdq9TKGPbyCubhTcx e1yZQkzthjjubXZSxrNsiyrb+b8c5H30MwE1h/tCy4b1O/6Fz9vfsBe9/+fRQ6nKD8Ef 6nf911ee2Cj/r/RxSXqwk+vYfefGfsmx5lL9cKiE0cTc9qyupZOLbRFkIT0AbLaQtV42 aH8R2BJNzBDpDDo5nJoTk2xnJojUMacumXg5loChLPyv2vhyek3qUIY4NWn8GEkcke5I 4/sznX0NGUl2y6ChncX57zdgGKlOm7+qmfbjS9Maa9o2VlWckYPU5YjujgchVB4XSuti z+Zg==
In-reply-to: <alpine.LFD.2.00.1402181001530.2216@xxxxxxxxxxxxxxxxxxxxx>
References: <1391319874-3203-1-git-send-email-linkinjeon@xxxxxxxxx> <alpine.LFD.2.00.1402111209450.2225@xxxxxxxxxxxxxxxxxxxxx> <CAKYAXd-bD6ZZgpc9E8V1kD9Dj2wrCkbi1i6drNBdUAwsMiv5gg@xxxxxxxxxxxxxx> <alpine.LFD.2.00.1402181001530.2216@xxxxxxxxxxxxxxxxxxxxx>
2014-02-18 18:05 GMT+09:00, LukÃÅ Czerner <lczerner@xxxxxxxxxx>:
> On Wed, 12 Feb 2014, Namjae Jeon wrote:
>
>> Date: Wed, 12 Feb 2014 11:28:35 +0900
>> From: Namjae Jeon <linkinjeon@xxxxxxxxx>
>> To: LukÃÅ Czerner <lczerner@xxxxxxxxxx>
>> Cc: viro@xxxxxxxxxxxxxxxxxx, david@xxxxxxxxxxxxx, bpm@xxxxxxx,
>> tytso@xxxxxxx,
>>     adilger.kernel@xxxxxxxxx, jack@xxxxxxx, mtk.manpages@xxxxxxxxx,
>>     linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx,
>>     linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,
>>     Namjae Jeon <namjae.jeon@xxxxxxxxxxx>,
>>     Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
>> Subject: Re: [PATCH RESEND 3/10] ext4: Add support
>> FALLOC_FL_COLLAPSE_RANGE
>>     for fallocate
>>
>> 2014-02-11 20:59 GMT+09:00, LukÃÅ Czerner <lczerner@xxxxxxxxxx>:
>> > On Sun, 2 Feb 2014, Namjae Jeon wrote:
>> >
>> >> Date: Sun,  2 Feb 2014 14:44:34 +0900
>> >> From: Namjae Jeon <linkinjeon@xxxxxxxxx>
>> >> To: viro@xxxxxxxxxxxxxxxxxx, david@xxxxxxxxxxxxx, bpm@xxxxxxx,
>> >> tytso@xxxxxxx,
>> >>     adilger.kernel@xxxxxxxxx, jack@xxxxxxx, mtk.manpages@xxxxxxxxx
>> >> Cc: linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx,
>> >>     linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,
>> >>     Namjae Jeon <linkinjeon@xxxxxxxxx>, Namjae Jeon
>> >> <namjae.jeon@xxxxxxxxxxx>,
>> >>     Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
>> >> Subject: [PATCH RESEND 3/10] ext4: Add support
>> >> FALLOC_FL_COLLAPSE_RANGE
>> >> for
>> >>     fallocate
>> >>
>> >> From: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
>> >>
>> >> Add support FALLOC_FL_COLLAPSE_RANGE for fallocate
>> Hi Lukas.
>> >
>> > Description is missing here, please provide FALLOC_FL_COLLAPSE_RANGE
>> > description so people know what it's supposed to be doing.
>> >
>> > more comments bellow.
>> Okay, I will udpate.
>> >
>> > Thanks!
>> > -Lukas
>
> Hi,
Hi Lukas.
>
> you may have noticed my patches for new FALLOC_FL_ZERO_RANGE
> fallocate flag. This changes things around the same area as your
> patches does so we should probably figure out which are going to
> land in first and then rebase the other on top of that.
Yes, I have seen your patches. I think that VFS + XFS patches for
FALLOC_FL_COLLAPSE_RANGE have got a fair amount of review from Dave.
So they are almost ready. I will post collapse range v5 patches after
fixing some minor comments tonight or tommorow.
If there will be no more comments for XFS patch, VFS + XFS patches can
go through to xfs tree by Dave.
I think that Ext4 collapse range could go at a later time.(Need your
reviewed-by tag)
If still there are comments for xfs patch, I will rebase on top of your patch.
>
> One concern I have is that I have not seen any tests provided to
> verify the feature. But I just may have missed it. Do you have any
> xfstests test or at least fsx and fsstress patches to provide
> support for testing FALLOC_FL_COLLAPSE_RANGE ? Patches for
> util_linux might also be handy.
Yes, There are 5 new xfstests cases in this patch-set. these will also
be posted with collapse range patch-set soon.

Thanks :)
>
> Thanks!
> -Lukas

<Prev in Thread] Current Thread [Next in Thread>