xfs
[Top] [All Lists]

Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for f

To: LukÃÅ Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 18 Feb 2014 20:46:44 +1100
Cc: Namjae Jeon <linkinjeon@xxxxxxxxx>, viro@xxxxxxxxxxxxxxxxxx, bpm@xxxxxxx, tytso@xxxxxxx, adilger.kernel@xxxxxxxxx, jack@xxxxxxx, mtk.manpages@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Namjae Jeon <namjae.jeon@xxxxxxxxxxx>, Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <alpine.LFD.2.00.1402181001530.2216@xxxxxxxxxxxxxxxxxxxxx>
References: <1391319874-3203-1-git-send-email-linkinjeon@xxxxxxxxx> <alpine.LFD.2.00.1402111209450.2225@xxxxxxxxxxxxxxxxxxxxx> <CAKYAXd-bD6ZZgpc9E8V1kD9Dj2wrCkbi1i6drNBdUAwsMiv5gg@xxxxxxxxxxxxxx> <alpine.LFD.2.00.1402181001530.2216@xxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Feb 18, 2014 at 10:05:49AM +0100, LukÃÅ Czerner wrote:
> On Wed, 12 Feb 2014, Namjae Jeon wrote:
> 
> > Date: Wed, 12 Feb 2014 11:28:35 +0900
> > From: Namjae Jeon <linkinjeon@xxxxxxxxx>
> > To: LukÃÅ Czerner <lczerner@xxxxxxxxxx>
> > Cc: viro@xxxxxxxxxxxxxxxxxx, david@xxxxxxxxxxxxx, bpm@xxxxxxx, 
> > tytso@xxxxxxx,
> >     adilger.kernel@xxxxxxxxx, jack@xxxxxxx, mtk.manpages@xxxxxxxxx,
> >     linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx,
> >     linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,
> >     Namjae Jeon <namjae.jeon@xxxxxxxxxxx>,
> >     Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
> > Subject: Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE
> >     for fallocate
> > 
> > 2014-02-11 20:59 GMT+09:00, LukÃÅ Czerner <lczerner@xxxxxxxxxx>:
> > > On Sun, 2 Feb 2014, Namjae Jeon wrote:
> > >
> > >> Date: Sun,  2 Feb 2014 14:44:34 +0900
> > >> From: Namjae Jeon <linkinjeon@xxxxxxxxx>
> > >> To: viro@xxxxxxxxxxxxxxxxxx, david@xxxxxxxxxxxxx, bpm@xxxxxxx,
> > >> tytso@xxxxxxx,
> > >>     adilger.kernel@xxxxxxxxx, jack@xxxxxxx, mtk.manpages@xxxxxxxxx
> > >> Cc: linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx,
> > >>     linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,
> > >>     Namjae Jeon <linkinjeon@xxxxxxxxx>, Namjae Jeon
> > >> <namjae.jeon@xxxxxxxxxxx>,
> > >>     Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
> > >> Subject: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE
> > >> for
> > >>     fallocate
> > >>
> > >> From: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
> > >>
> > >> Add support FALLOC_FL_COLLAPSE_RANGE for fallocate
> > Hi Lukas.
> > >
> > > Description is missing here, please provide FALLOC_FL_COLLAPSE_RANGE
> > > description so people know what it's supposed to be doing.
> > >
> > > more comments bellow.
> > Okay, I will udpate.
> > >
> > > Thanks!
> > > -Lukas
> 
> Hi,
> 
> you may have noticed my patches for new FALLOC_FL_ZERO_RANGE
> fallocate flag. This changes things around the same area as your
> patches does so we should probably figure out which are going to
> land in first and then rebase the other on top of that.
> 
> One concern I have is that I have not seen any tests provided to
> verify the feature. But I just may have missed it. Do you have any
> xfstests test or at least fsx and fsstress patches to provide
> support for testing FALLOC_FL_COLLAPSE_RANGE ? Patches for
> util_linux might also be handy.

There were 5 xfstests patches posted that used the
_test_generic_punch infrastructure to test this functionality.
See the december 08 index here, search for "shared/00[1-5]":

http://oss.sgi.com/archives/xfs/2013-12/index.html

They need a little rework, but otherwise the test code is there.
Having the feature added to fsx and fsstress would probably be a
good idea, though.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>