| To: | Eric Sandeen <sandeen@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2] xfstests: test for atime-related mount options |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 18 Feb 2014 12:05:03 +1100 |
| Cc: | Koen De Wit <koen.de.wit@xxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <530273CD.3090303@xxxxxxxxxx> |
| References: | <1392668720-6135-1-git-send-email-koen.de.wit@xxxxxxxxxx> <530273CD.3090303@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Feb 17, 2014 at 02:40:45PM -0600, Eric Sandeen wrote: > On 2/17/14, 2:25 PM, Koen De Wit wrote: > > Tests the noatime, relatime, strictatime and nodiratime mount options. > > > > There is an extra check for Btrfs to ensure that the access time is > > never updated on read-only subvolumes. (Regression test for bug fixed > > with commit 93fd63c2f001ca6797c6b15b696a484b165b4800) > > I think this looks ok. Only little nit is that _require_relatime > now implicitly requires scratch, but *shrug* it was Dave's idea. ;) There's a _require_scratch call in there, so it's all good. ;) Thanks Koen! > Thanks! > > Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx> And thanks for the reivew, Eric ;) Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 0/6][RFC] Introduce FALLOC_FL_ZERO_RANGE flag for fallocate, Dave Chinner |
|---|---|
| Next by Date: | Re: 3.14-rc2 XFS backtrace because irqs_disabled., Dave Chinner |
| Previous by Thread: | Re: [PATCH v2] xfstests: test for atime-related mount options, Eric Sandeen |
| Next by Thread: | Aurora E-Newsletter Edition 106, Aurora Yacht Logistics |
| Indexes: | [Date] [Thread] [Top] [All Lists] |