xfs
[Top] [All Lists]

Re: 3.14-rc2 XFS backtrace because irqs_disabled.

To: Oleg Nesterov <oleg@xxxxxxxxxx>
Subject: Re: 3.14-rc2 XFS backtrace because irqs_disabled.
From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Date: Mon, 17 Feb 2014 17:54:07 +0000
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Dave Jones <davej@xxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140217174648.GA6176@xxxxxxxxxx>
References: <20140215142700.GA15540@xxxxxxxxxx> <20140215152251.GY18016@xxxxxxxxxxxxxxxxxx> <20140215153631.GZ18016@xxxxxxxxxxxxxxxxxx> <20140215155838.GA18016@xxxxxxxxxxxxxxxxxx> <20140215174345.GA24799@xxxxxxxxxx> <20140215180520.GC18016@xxxxxxxxxxxxxxxxxx> <20140215184531.GA27314@xxxxxxxxxx> <20140217165735.GA29173@xxxxxxxxxx> <20140217174059.GD18016@xxxxxxxxxxxxxxxxxx> <20140217174648.GA6176@xxxxxxxxxx>
Sender: Al Viro <viro@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Feb 17, 2014 at 06:46:48PM +0100, Oleg Nesterov wrote:
> > pulling the logics *out* of kernel/signal.c and into arch/*.
> 
> Not really, I think.

How so?  You propose to make all architectures call do_coredump()
themselves, instead of having it done centrally.  It's more boilerplate
for all of them to get wrong.  And IME any boilerplate in that are
*will* be gotten wrong - I've gone through signal handling on all
architectures more than a few times and every time it caught a pile
of bugs...

<Prev in Thread] Current Thread [Next in Thread>