| To: | Al Viro <viro@xxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: 3.14-rc2 XFS backtrace because irqs_disabled. |
| From: | Oleg Nesterov <oleg@xxxxxxxxxx> |
| Date: | Mon, 17 Feb 2014 18:46:48 +0100 |
| Cc: | Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Dave Jones <davej@xxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140217174059.GD18016@xxxxxxxxxxxxxxxxxx> |
| References: | <20140215052531.GX18016@xxxxxxxxxxxxxxxxxx> <20140215142700.GA15540@xxxxxxxxxx> <20140215152251.GY18016@xxxxxxxxxxxxxxxxxx> <20140215153631.GZ18016@xxxxxxxxxxxxxxxxxx> <20140215155838.GA18016@xxxxxxxxxxxxxxxxxx> <20140215174345.GA24799@xxxxxxxxxx> <20140215180520.GC18016@xxxxxxxxxxxxxxxxxx> <20140215184531.GA27314@xxxxxxxxxx> <20140217165735.GA29173@xxxxxxxxxx> <20140217174059.GD18016@xxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On 02/17, Al Viro wrote: > > On Mon, Feb 17, 2014 at 05:57:35PM +0100, Oleg Nesterov wrote: > > > Looks like, this is all is really nasty. Actually, I think siginfo on > > stack is not that bad if we are going to do handle_signal() or restart, > > perhaps we can do the extra kmalloc/memcpy/kfree for do_coredump(). > > Something like below. > > Yecchhhh... You've just broken every architecture other than x86, Of course, this is only to explain what I meant. > and to > fix them you'll need to massage every get_signal()/get_signal_to_deliver() > user out there, Yes. > pulling the logics *out* of kernel/signal.c and into arch/*. Not really, I think. Of course this change should be cleanuped. And it should not require to change all architectures at once. > This is just plain wrong. I agree, this change is also ugly. Oleg. |
| Previous by Date: | Re: 3.14-rc2 XFS backtrace because irqs_disabled., Al Viro |
|---|---|
| Next by Date: | Re: 3.14-rc2 XFS backtrace because irqs_disabled., Al Viro |
| Previous by Thread: | Re: 3.14-rc2 XFS backtrace because irqs_disabled., Al Viro |
| Next by Thread: | Re: 3.14-rc2 XFS backtrace because irqs_disabled., Al Viro |
| Indexes: | [Date] [Thread] [Top] [All Lists] |