xfs
[Top] [All Lists]

Re: [PATCH] xfstests: add regression test for btrfs incremental send

To: Filipe David Manana <fdmanana@xxxxxxxxx>
Subject: Re: [PATCH] xfstests: add regression test for btrfs incremental send
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 17 Feb 2014 12:44:16 +1100
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, "linux-btrfs@xxxxxxxxxxxxxxx" <linux-btrfs@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <CAL3q7H4JLbMS+JL4h4du60S1vKFtvceP-Mx-e=0v4nTBwjkATA@xxxxxxxxxxxxxx>
References: <1392408522-764-1-git-send-email-fdmanana@xxxxxxxxx> <1392596438-6509-1-git-send-email-fdmanana@xxxxxxxxx> <20140217011929.GA13997@dastard> <CAL3q7H4JLbMS+JL4h4du60S1vKFtvceP-Mx-e=0v4nTBwjkATA@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Feb 17, 2014 at 01:36:02AM +0000, Filipe David Manana wrote:
> On Monday, February 17, 2014, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> 
> > On Mon, Feb 17, 2014 at 12:20:38AM +0000, Filipe David Borba Manana wrote:
> > > Test for a btrfs incremental send issue where we end up sending a
> > > wrong section of data from a file extent if the corresponding file
> > > extent is compressed and the respective file extent item has a non
> > > zero data offset.
> > >
> > > Fixed by the following linux kernel btrfs patch:
> > >
> > >    Btrfs: use right clone root offset for compressed extents
> > >
> > > Signed-off-by: Filipe David Borba Manana <fdmanana@xxxxxxxxx<javascript:;>
> > >
> > > ---
> > >
> > > V2: Made the test more reliable. Now it doesn't depend anymore of btrfs'
> > >     hole punch implementation leaving hole file extent items when we
> > punch
> > >     beyond the file's current size.
> > > V3: Filter xfs_io output and make less use of the run_check function, as
> > >     suggested by Dave Chinner.
> >
> > Awesome. Thanks for the quick turn around.
> >
> > >  common/rc           |    5 +++
> > >  tests/btrfs/040     |  119
> > +++++++++++++++++++++++++++++++++++++++++++++++++++
> > >  tests/btrfs/040.out |    9 ++++
> > >  tests/btrfs/group   |    1 +
> > >  4 files changed, 134 insertions(+)
> > >  create mode 100755 tests/btrfs/040
> > >  create mode 100644 tests/btrfs/040.out
> > >
> > > diff --git a/common/rc b/common/rc
> > > index e91568b..27be009 100644
> > > --- a/common/rc
> > > +++ b/common/rc
> > > @@ -2207,6 +2207,11 @@ run_check()
> > >       "$@" >> $seqres.full 2>&1 || _fail "failed: '$@'"
> > >  }
> > >
> > > +_run_btrfs_util_prog()
> > > +{
> > > +     run_check $BTRFS_UTIL_PROG $*
> > > +}
> >
> > Can you do a cleanup of all the other btrfs tests that can use this?
> 
> 
> Ok. I just did that for all the test cases not yet merged, as you probably
> noticed already.

Yes, I did ;)

> For the ones already in the repository, I'll see if I can do it soon this
> coming week.

Great! Thanks for doing this.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>