xfs
[Top] [All Lists]

Re: [PATCH] xfstests: add regression test for btrfs incremental send

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: add regression test for btrfs incremental send
From: Filipe David Manana <fdmanana@xxxxxxxxx>
Date: Mon, 17 Feb 2014 01:36:02 +0000
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, "linux-btrfs@xxxxxxxxxxxxxxx" <linux-btrfs@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=a7ojc8zXlkdwVTJ0+gBvqGPYgM9KwIOa7A5QG8zkwp0=; b=mfZLhW1lPfEpHSy+76xZWha7uE47aYllRcS0XvUSLjbWBYQ8JWf416iG4Y/w6vUN3t PuQ6VJkORv3RHazCk7nO8J4F+us0EYAq5ZVPcF7y3zcGEK53aVCaP14Tcc3XjKjkMBDE YNTEpMiNZ1OVyr8AalYby899V1IcXzb5Y8gS1zvupRyR5N6/Z5/AkJxAcfJgIdTQayZA sTMq9HEB9Da7p6otyO2U+TyjD3WG/11fYGNL5c55gM7xKkOzC89uHo8YwQUtfs8N9o33 tfIuERbanZiZwND1fNekWYsm+EBKGUsrDxtzKPlMncVlMPVEjWirhw4KuLqO1Pe5rgBC 8oWA==
In-reply-to: <20140217011929.GA13997@dastard>
References: <1392408522-764-1-git-send-email-fdmanana@xxxxxxxxx> <1392596438-6509-1-git-send-email-fdmanana@xxxxxxxxx> <20140217011929.GA13997@dastard>
Reply-to: fdmanana@xxxxxxxxx


On Monday, February 17, 2014, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
On Mon, Feb 17, 2014 at 12:20:38AM +0000, Filipe David Borba Manana wrote:
> Test for a btrfs incremental send issue where we end up sending a
> wrong section of data from a file extent if the corresponding file
> extent is compressed and the respective file extent item has a non
> zero data offset.
>
> Fixed by the following linux kernel btrfs patch:
>
> Â ÂBtrfs: use right clone root offset for compressed extents
>
> Signed-off-by: Filipe David Borba Manana <fdmanana@xxxxxxxxx>
> ---
>
> V2: Made the test more reliable. Now it doesn't depend anymore of btrfs'
> Â Â hole punch implementation leaving hole file extent items when we punch
> Â Â beyond the file's current size.
> V3: Filter xfs_io output and make less use of the run_check function, as
> Â Â suggested by Dave Chinner.

Awesome. Thanks for the quick turn around.

> Âcommon/rc      |  Â5 +++
> Âtests/btrfs/040 Â Â | Â119 +++++++++++++++++++++++++++++++++++++++++++++++++++
> Âtests/btrfs/040.out | Â Â9 ++++
> Âtests/btrfs/group  |  Â1 +
> Â4 files changed, 134 insertions(+)
> Âcreate mode 100755 tests/btrfs/040
> Âcreate mode 100644 tests/btrfs/040.out
>
> diff --git a/common/rc b/common/rc
> index e91568b..27be009 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2207,6 +2207,11 @@ run_check()
> Â Â Â "$@" >> $seqres.full 2>&1 || _fail "failed: '$@'"
> Â}
>
> +_run_btrfs_util_prog()
> +{
> + Â Â run_check $BTRFS_UTIL_PROG $*
> +}

Can you do a cleanup of all the other btrfs tests that can use this?

Ok. I just didÂthat for all the test cases not yet merged, as you probably noticed already.
For the ones already in the repository, I'll see if I can do it soon this coming week.

Thanks
Â

Cheers,

Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx


--
Filipe David Manana,

"Reasonable men adapt themselves to the world.
ÂUnreasonable men adapt the world to themselves.
ÂThat's why all progress depends on unreasonable men."

<Prev in Thread] Current Thread [Next in Thread>