On 02/14/14 13:51, Mark Tinguely wrote:
On 02/13/14 20:20, Dave Chinner wrote:
On Thu, Feb 13, 2014 at 01:30:00PM -0600, Mark Tinguely wrote:
On 01/23/14 04:23, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>
Write_buf/write_index use confusing boolean values for return,
meaning that it's hard to tell what the correct error return is
supposed to be. Convert them to return zero on success or a
negative errno otherwise so that it's clear what the error case is.
Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
Looks like this patch broke metadumps on some corrupted filesystems.
This is a legacy filesystem that has zeroes overwriting the
SB/AGF/AGI on AG 1/2/3:
# xfs_metadump -wgo /dev/sda8 myfile.metadata
xfs_metadump: cannot init perag data (117). Continuing anyway.
Copied 64 of 64 inodes (0 of 4 AGs) xfs_agf_write_verify: XF
write_buf: write verifer failed on bno 0x1100919/0x200
Where did it crash? Can you post the stack trace from gdb? Even
better, can you send a patch to fix the problem? ;)
No crash, just exits without performing the dump.
The error from the verifier prevents the metadump from completing.
You will want to fix it another way...
db/metadump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -209,7 +209,7 @@ write_buf(
_("%s: write verifer failed on bno 0x%llx/0x%x\n"),
__func__, (long long)buf->bp->b_bn,
- return -buf->bp->b_error;
+ return 0;