xfs
[Top] [All Lists]

Re: [PATCH v3 0/3] __btrfs_drop_extents() BUG_ON reproducer

To: David Disseldorp <ddiss@xxxxxxx>
Subject: Re: [PATCH v3 0/3] __btrfs_drop_extents() BUG_ON reproducer
From: Filipe David Manana <fdmanana@xxxxxxxxx>
Date: Fri, 14 Feb 2014 13:39:24 +0000
Cc: "linux-btrfs@xxxxxxxxxxxxxxx" <linux-btrfs@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=vDo2IKmQ61PcgSLXPvvfXrNo3Ap6lZ2MSiYTBdCPEMY=; b=D7ug4D9lp5O1ph771ZSaJqhudUVvWTR3xQiSaGnfZvhL884sncERJ+YDPjPVg0KNVO /830DoNPtdC7ST3TAkk8SLg9JTiP3VGNs/fslHMs6HN/9Hix7sJ0737R2JBaMMnVcU6M 3qvaU1v4V0RNCiZseaiOo92d5674I2N0PNxBDicHASoNEJzeQ0JyNreBMHm2f8gv//FB weENCFVwTOIEmPC7lvFRS4xoOZTG5wUONHyGujoHtof5oLkX4Ja6GL202V93/vOj072P uJaLLv5wmx1WvqpACkKV26S60CcWKAg5hkSBLZeidCxpNPQ0sZxTbvOX8Wjc2k35QogO X5vA==
In-reply-to: <20140214134656.7c1f2544@xxxxxxxxxx>
References: <1391769341-20688-1-git-send-email-ddiss@xxxxxxx> <20140214134656.7c1f2544@xxxxxxxxxx>
Reply-to: fdmanana@xxxxxxxxx
On Fri, Feb 14, 2014 at 12:46 PM, David Disseldorp <ddiss@xxxxxxx> wrote:
> Ping, any Btrfsers get a chance to look at this patch series?
> I'd like to get it into the QA tree.

If no one else gets there first, I'll take a look at it soon.
thanks

>
> On Fri,  7 Feb 2014 11:35:38 +0100, David Disseldorp wrote:
>
>> This patch-set provides a reproducer for hitting the 3.14.0-rc1 BUG_ON()
>> at:
>>  692 int __btrfs_drop_extents(struct btrfs_trans_handle *trans,
>> ...
>>  839                 /*
>>  840                  *  | ---- range to drop ----- |
>>  841                  *      | -------- extent -------- |
>>  842                  */
>>  843                 if (start <= key.offset && end < extent_end) {
>>  844                         BUG_ON(extent_type == BTRFS_FILE_EXTENT_INLINE);
>>  845
>>  846                         memcpy(&new_key, &key, sizeof(new_key));
>>
>> The first patch adds a small cloner binary which is used by btrfs/035 to
>> dispatch BTRFS_IOC_CLONE_RANGE requests.
>>
>> This workload resembles that of Samba's vfs_btrfs module, when a Windows
>> client restores a file from a shadow-copy (snapshot) using server-side
>> copy requests.
>>
>> Changes since V2:
>> - Remove explicit write error checks
>>
>> Changes since V1:
>> - Use strtoull instead of atoi
>> - Print error conditions in cloner
>> - Check for cloner binary before running test
>> - Continue test on failure
>> - Add cloner to .gitignore
>>
>> Feedback appreciated.
>>
>> Cheers, David
>>
>>
>>  .gitignore          |   1 +
>>  configure.ac        |   1 +
>>  src/Makefile        |   2 +-
>>  src/cloner.c        | 192 
>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  tests/btrfs/035     |  77 
>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  tests/btrfs/035.out |   3 +++
>>  tests/btrfs/group   |   1 +
>>  7 files changed, 276 insertions(+), 1 deletion(-)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Filipe David Manana,

"Reasonable men adapt themselves to the world.
 Unreasonable men adapt the world to themselves.
 That's why all progress depends on unreasonable men."

<Prev in Thread] Current Thread [Next in Thread>