xfs
[Top] [All Lists]

Re: [PATCH 1/5] metadump: sanitise write_buf/index return values

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH 1/5] metadump: sanitise write_buf/index return values
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 14 Feb 2014 13:20:53 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52FD1D38.1010006@xxxxxxx>
References: <1390472635-17225-1-git-send-email-david@xxxxxxxxxxxxx> <1390472635-17225-2-git-send-email-david@xxxxxxxxxxxxx> <52FD1D38.1010006@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Feb 13, 2014 at 01:30:00PM -0600, Mark Tinguely wrote:
> On 01/23/14 04:23, Dave Chinner wrote:
> >From: Dave Chinner<dchinner@xxxxxxxxxx>
> >
> >Write_buf/write_index use confusing boolean values for return,
> >meaning that it's hard to tell what the correct error return is
> >supposed to be.  Convert them to return zero on success or a
> >negative errno otherwise so that it's clear what the error case is.
> >
> >Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
> >---
> 
> Looks like this patch broke metadumps on some corrupted filesystems.
> This is a legacy filesystem that has zeroes overwriting the
> SB/AGF/AGI on AG 1/2/3:
> 
> 
> # xfs_metadump -wgo /dev/sda8 myfile.metadata
> xfs_agf_read_verify: XFS_CORRUPTION_ERROR
> xfs_metadump: cannot init perag data (117). Continuing anyway.
> Copied 64 of 64 inodes (0 of 4 AGs) xfs_agf_write_verify: XF
> S_CORRUPTION_ERROR
> write_buf: write verifer failed on bno 0x1100919/0x200
> (no output)

Where did it crash? Can you post the stack trace from gdb? Even
better, can you send a patch to fix the problem? ;)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>