Re: [PATCH V3] xfs: skip verification on initial "guess" superblock read

xfs

Re: [PATCH V3] xfs: skip verification on initial "guess" superblock read

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH V3] xfs: skip verification on initial "guess" superblock read
From:	Eric Sandeen <sandeen@xxxxxxxxxxx>
Date:	Thu, 13 Feb 2014 20:04:07 -0600
Cc:	Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20140214002708.GO13997@dastard>
References:	<52FD3C59.3050400@xxxxxxxxxx> <52FD55FC.1000103@xxxxxxxxxxx> <20140214002708.GO13997@dastard>
User-agent:	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

On 2/13/14, 6:27 PM, Dave Chinner wrote:

> Looks fine. I'll run it through some testing and we can go from
> there. FWIW, does this make your "check the sector size in the sb
> verifier" patch redundant?

Well, it'll be safe for the primary SB, but I assume that a corrupted
secondary would still trip things up.

I think that at this point we can switch to using BBTOB(bp->b_length)
in the verifier and be safe.  I'll look into it.

-Eric

> Cheers,
> 
> Dave.
>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] xfs: skip verification on initial "guess" superblock read, Eric Sandeen Re: [PATCH] xfs: skip verification on initial "guess" superblock read, Eric Sandeen Re: [PATCH] xfs: skip verification on initial "guess" superblock read, Dave Chinner Re: [PATCH] xfs: skip verification on initial "guess" superblock read, Eric Sandeen [PATCH V2] xfs: skip verification if initial sb read is wrong length, Eric Sandeen Re: [PATCH V2] xfs: skip verification if initial sb read is wrong length, Dave Chinner [PATCH V3] xfs: skip verification on initial "guess" superblock read, Eric Sandeen Re: [PATCH V3] xfs: skip verification on initial "guess" superblock read, Dave Chinner Re: [PATCH V3] xfs: skip verification on initial "guess" superblock read, Eric Sandeen <=

Previous by Date:	Re: 3.14.0-rc2: WARNING: at mm/slub.c:1007, Christian Kujau
Next by Date:	Re: [PATCH 1/5] metadump: sanitise write_buf/index return values, Dave Chinner
Previous by Thread:	Re: [PATCH V3] xfs: skip verification on initial "guess" superblock read, Dave Chinner
Next by Thread:	[XFS updates] XFS development tree branch, for-next, updated. xfs-for-linus-v3.14-rc1-2-12935-ga64b760, xfs
Indexes:	[Date] [Thread] [Top] [All Lists]