| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2] xfs_db: fix the setting of unaligned directory fields |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Wed, 12 Feb 2014 15:37:13 -0600 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140212002222.GO13647@dastard> |
| References: | <20140210230923.268327906@xxxxxxx> <20140211013145.GA13647@dastard> <52FA3141.20901@xxxxxxx> <20140212002222.GO13647@dastard> |
| User-agent: | Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 |
On 02/11/14 18:22, Dave Chinner wrote: On Tue, Feb 11, 2014 at 08:18:41AM -0600, Mark Tinguely wrote:On 02/10/14 19:31, Dave Chinner wrote: ... Hence I'd suggest that "if (bit_field & NBBY) return NULL;" is appropriate for hex block format input, and the input should never be treated as a host-endian integer... Cheers, Dave. I don't like having the hex block format as an integer input. My change would change the result if used as an integer, I just trying to keep compatibility with the previous code. I will gladly leave the hex block input alone and remove the test that uses it as an integer. --Mark. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: 3.14-rc2 XFS backtrace because irqs_disabled., Linus Torvalds |
|---|---|
| Next by Date: | [XFS updates] XFS development tree branch, xfs-fixes-for-3.14-rc3, updated. xfs-for-linus-v3.14-rc1-2-12923-g55daffa, xfs |
| Previous by Thread: | Re: [PATCH v2] xfs_db: fix the setting of unaligned directory fields, Dave Chinner |
| Next by Thread: | [PATCH v3] xfs_db: fix the setting of unaligned directory fields, Mark Tinguely |
| Indexes: | [Date] [Thread] [Top] [All Lists] |