[Top] [All Lists]

[PATCH V2] xfstests: check that junk in V4 superblocks doesn't break gro

To: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Subject: [PATCH V2] xfstests: check that junk in V4 superblocks doesn't break growfs
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 11 Feb 2014 20:26:49 -0600
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52FAD989.6020000@xxxxxxxxxx>
References: <52FAD989.6020000@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.3.0
Test that we properly ignore old growfs-induced junk in the unused
portion of secondary V4 superblocks; at one point this would
trip up the verifiers, and cause a subsequent growfs to fail.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

V2, fix wrong summary for commit in question, in the test comments

diff --git a/tests/xfs/307 b/tests/xfs/307
new file mode 100755
index 0000000..d3c768f
--- /dev/null
+++ b/tests/xfs/307
@@ -0,0 +1,75 @@
+#! /bin/bash
+# FS QA Test No. 307
+# Test that garbage in old v4 superblocks doesn't trip verifiers during growfs
+# Older kernels sometimes left garbage in the unused portions
+# of the superblock during growfs; with the new verifiers this initially
+# caused failures during a subsequent growfs; see
+# 10e6e65 xfs: be more forgiving of a v4 secondary sb w/ junk in v5 fields
+# for further explanation.  (NB: while the commit log was good, the
+# patch had a bug which was subsequently fixed)
+# Copyright (c) 2014 Red Hat, Inc.  All Rights Reserved.
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# GNU General Public License for more details.
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+seq=`basename $0`
+echo "QA output created by $seq"
+status=1       # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+    cd /
+    rm -f $tmp.*
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+# Modify as appropriate.
+_supported_fs xfs
+_supported_os Linux
+# So we can explicitly turn it _off_:
+rm -f $seqres.full
+_scratch_mkfs_xfs -m crc=0 -d size=128m >> $seqres.full 2>&1 || _fail "mkfs 
+# Scribble past a couple V4 secondary superblocks to populate sb_crc
+# (We can't write to the structure member because it doesn't exist
+# on a v4 superblock, so we use the data type & "write fill")
+$XFS_DB_PROG -x -c "sb 1" -c "type data" -c "write fill 0xff 224 4" 
+$XFS_DB_PROG -x -c "sb 2" -c "type data" -c "write fill 0xff 224 4" 
+# This should pass
+$XFS_GROWFS_PROG $SCRATCH_MNT >> $seqres.full 2>&1 || _fail "growfs failed"
+# success, all done
diff --git a/tests/xfs/307.out b/tests/xfs/307.out
new file mode 100644
index 0000000..260c17c
--- /dev/null
+++ b/tests/xfs/307.out
@@ -0,0 +1 @@
+QA output created by 307
diff --git a/tests/xfs/group b/tests/xfs/group
index 279ffe2..fbcd3e3 100644
--- a/tests/xfs/group
+++ b/tests/xfs/group
@@ -186,3 +186,4 @@
 304 auto quick quota
 305 auto quota
 306 auto stress log metadata repair
+307 auto quick growfs

xfs mailing list

<Prev in Thread] Current Thread [Next in Thread>