xfs
[Top] [All Lists]

Re: [PATCH] xfs: xfs_sb_read_verify() doesn't flag bad crcs on primary s

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: xfs_sb_read_verify() doesn't flag bad crcs on primary sb
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 11 Feb 2014 17:24:14 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52FAA85F.1060708@xxxxxxxxxx>
References: <52FAA85F.1060708@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 02/11/14 16:46, Eric Sandeen wrote:
My earlier commit 10e6e65 deserves a layer or two of brown paper
bags.  The logic in that commit means that a CRC failure on the
primary superblock will *never* result in an error return.

Hopefully this fixes it, so that we always return the error
if it's a primary superblock, otherwise only if the filesystem
has CRCs enabled.

Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
---


Augh, blame the reviewer who is always sdrawkcab:)

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>