| To: | xfs-oss <xfs@xxxxxxxxxxx> |
|---|---|
| Subject: | [PATCH] xfs: xfs_sb_read_verify() doesn't flag bad crcs on primary sb |
| From: | Eric Sandeen <sandeen@xxxxxxxxxx> |
| Date: | Tue, 11 Feb 2014 16:46:55 -0600 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
My earlier commit 10e6e65 deserves a layer or two of brown paper
bags. The logic in that commit means that a CRC failure on the
primary superblock will *never* result in an error return.
Hopefully this fixes it, so that we always return the error
if it's a primary superblock, otherwise only if the filesystem
has CRCs enabled.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---
diff --git a/fs/xfs/xfs_sb.c b/fs/xfs/xfs_sb.c
index b7c9aea..5071ccb 100644
--- a/fs/xfs/xfs_sb.c
+++ b/fs/xfs/xfs_sb.c
@@ -614,7 +614,7 @@ xfs_sb_read_verify(
if (!xfs_verify_cksum(bp->b_addr, be16_to_cpu(dsb->sb_sectsize),
offsetof(struct xfs_sb, sb_crc))) {
/* Only fail bad secondaries on a known V5 filesystem */
- if (bp->b_bn != XFS_SB_DADDR &&
+ if (bp->b_bn == XFS_SB_DADDR ||
xfs_sb_version_hascrc(&mp->m_sb)) {
error = EFSCORRUPTED;
goto out_error;
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 6/7] xfs: add xfs_verifier_error(), Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] xfs: xfs_sb_read_verify() doesn't flag bad crcs on primary sb, Mark Tinguely |
| Previous by Thread: | Применение водного законодательства в 2014 году, АГЕНТСТВО ВОДНЫХ РЕСУРСОВ |
| Next by Thread: | Re: [PATCH] xfs: xfs_sb_read_verify() doesn't flag bad crcs on primary sb, Mark Tinguely |
| Indexes: | [Date] [Thread] [Top] [All Lists] |