xfs
[Top] [All Lists]

Re: [PATCH v2] xfstests: btrfs/004: fix to make test really work

To: Wang Shilong <wangsl.fnst@xxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH v2] xfstests: btrfs/004: fix to make test really work
From: Josef Bacik <jbacik@xxxxxx>
Date: Tue, 11 Feb 2014 08:25:31 -0500
Cc: <linux-btrfs@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=message-id : date : from : mime-version : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=WqHHwX119HrDuITXnKdvx/nZZfZMN/7kqaJYf0OyQ1g=; b=L1xPmvkpFf0EGCWl69CoggeweSRL+CMJvycki8fX0u2PmOVGxsvgT+QkrXaJkUK5VYXf FyxmX1n9udjLl+TIUUVSh/2d1ENZe1xfZL7TdNoClxacAMgdkCxlW40PvsYwNBUu78Tp x7wR+dIEb0HhL4AfS6yUXIQWDEv91s1yQOA=
In-reply-to: <1392113204-29237-1-git-send-email-wangsl.fnst@xxxxxxxxxxxxxx>
References: <1392113204-29237-1-git-send-email-wangsl.fnst@xxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0


On 02/11/2014 05:06 AM, Wang Shilong wrote:
So i was wondering why test 004 could pass my previous wrong
kernel patch while it defenitely should not.

By some debugging, i found here perl script is wrong, we did not
filter out anything and this unit test did not work acutally.so
it came out we will never fail this test.

Signed-off-by: Wang Shilong <wangsl.fnst@xxxxxxxxxxxxxx>
---

This works for me, you can add

Reviewed-by: Josef Bacik <jbacik@xxxxxx>

Thanks,

Josef

<Prev in Thread] Current Thread [Next in Thread>