xfs
[Top] [All Lists]

Re: [PATCH v3 07/11] xfs: refactor xfs_difree() inobt bits into xfs_difr

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v3 07/11] xfs: refactor xfs_difree() inobt bits into xfs_difree_inobt() helper
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 11 Feb 2014 18:19:27 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1391536182-9048-8-git-send-email-bfoster@xxxxxxxxxx>
References: <1391536182-9048-1-git-send-email-bfoster@xxxxxxxxxx> <1391536182-9048-8-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Feb 04, 2014 at 12:49:38PM -0500, Brian Foster wrote:
> Refactor xfs_difree() in preparation for the finobt. xfs_difree()
> performs the validity checks against the ag and reads the agi
> header. The work of physically updating the inode allocation btree
> is pushed down into the new xfs_difree_inobt() helper.
> 
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>