Re: [PATCH] xfstests: btrfs/004: fix to make test really work

[Josef Bacik <jbacik@xxxxxx>]

On 02/10/2014 08:22 PM, Wang Shilong wrote:
> Hi Josef,
>
> On 02/11/2014 03:18 AM, Josef Bacik wrote:
> > On 02/10/2014 07:10 AM, Wang Shilong wrote:
> > > From: Wang Shilong <wangsl.fnst@xxxxxxxxxxxxxx>
> > >
> > > So i was wandering why test 004 could pass my previous wrong
> > > kernel patch while it defenitely should not.
> > >
> > > By some debugging, i found here perl script is wrong, we did not
> > > filter out anything and this unit test did not work acutally.so
> > > it came out we will never fail this test.
> > So now with this patch I'm failing it, is there some btrfs patch I 
> > need to make it not fail or is it still not supposed to fail normally 
> > and is this patch broken?  Thanks,
> You should not have updated my previous patch(Btrfs: switch to 
> btrfs_previous_extent_item()) when you fail this test.
> I update your latest btrfs-next which has updated my previous patch 
> and it can pass this case, did you miss that?
Hrm I must not have insmod'ed the new module, which now means I have to 
re-run all my tests, sigh.
Josef