xfs
[Top] [All Lists]

Re: [PATCH] xfstests: btrfs/004: fix to make test really work

To: Wang Shilong <wangsl.fnst@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: btrfs/004: fix to make test really work
From: Josef Bacik <jbacik@xxxxxx>
Date: Mon, 10 Feb 2014 21:01:57 -0500
Cc: Wang Shilong <wangshilong1991@xxxxxxxxx>, <xfs@xxxxxxxxxxx>, <linux-btrfs@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=message-id : date : from : mime-version : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=d+tFTiDHrLpkl6ml95e6imScgnm2EQW15wNuG6cnyTE=; b=LlEKGXkm6JAR5a2Q+NIzCjfNGiqvcitJIWLBc4OrYzoz4Bpf384LMBP4TcpR0qaxQJjG ScY7yzblNxcDdc9m7+GOafUkd4Epn39l04+zq0uYAje5N3RJHHU1YdjO9l5dAxl5s0yq egJJHyjO/s55QONfSNS0JD7ADD1bBBh7pmI=
In-reply-to: <52F97B3E.9060608@xxxxxxxxxxxxxx>
References: <1392034256-2412-1-git-send-email-wangshilong1991@xxxxxxxxx> <52F925EA.20600@xxxxxx> <52F97B3E.9060608@xxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

On 02/10/2014 08:22 PM, Wang Shilong wrote:
Hi Josef,

On 02/11/2014 03:18 AM, Josef Bacik wrote:


On 02/10/2014 07:10 AM, Wang Shilong wrote:
From: Wang Shilong <wangsl.fnst@xxxxxxxxxxxxxx>

So i was wandering why test 004 could pass my previous wrong
kernel patch while it defenitely should not.

By some debugging, i found here perl script is wrong, we did not
filter out anything and this unit test did not work acutally.so
it came out we will never fail this test.


So now with this patch I'm failing it, is there some btrfs patch I need to make it not fail or is it still not supposed to fail normally and is this patch broken? Thanks,
You should not have updated my previous patch(Btrfs: switch to btrfs_previous_extent_item()) when you fail this test. I update your latest btrfs-next which has updated my previous patch and it can pass this case, did you miss that?

Hrm I must not have insmod'ed the new module, which now means I have to re-run all my tests, sigh.

Josef

<Prev in Thread] Current Thread [Next in Thread>