[Top] [All Lists]

Re: [PATCH] xfstests: btrfs/004: fix to make test really work

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: btrfs/004: fix to make test really work
From: Wang Shilong <wangsl.fnst@xxxxxxxxxxxxxx>
Date: Tue, 11 Feb 2014 09:24:17 +0800
Cc: Wang Shilong <wangshilong1991@xxxxxxxxx>, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140210213944.GT13647@dastard>
References: <1392034256-2412-1-git-send-email-wangshilong1991@xxxxxxxxx> <20140210213944.GT13647@dastard>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130612 Thunderbird/17.0.6
On 02/11/2014 05:39 AM, Dave Chinner wrote:
On Mon, Feb 10, 2014 at 08:10:56PM +0800, Wang Shilong wrote:
From: Wang Shilong <wangsl.fnst@xxxxxxxxxxxxxx>

So i was wandering why test 004 could pass my previous wrong
kernel patch while it defenitely should not.

By some debugging, i found here perl script is wrong, we did not
filter out anything and this unit test did not work acutally.so
it came out we will never fail this test.

Signed-off-by: Wang Shilong <wangsl.fnst@xxxxxxxxxxxxxx>
  tests/btrfs/004 | 7 +++----
  1 file changed, 3 insertions(+), 4 deletions(-)
  mode change 100755 => 100644 tests/btrfs/004

diff --git a/tests/btrfs/004 b/tests/btrfs/004
old mode 100755
new mode 100644
index 14da9f1..17a6e34
--- a/tests/btrfs/004
+++ b/tests/btrfs/004
@@ -57,10 +57,9 @@ _require_command "/usr/sbin/filefrag"
rm -f $seqres.full -FILEFRAG_FILTER='if (/, blocksize (\d+)/) {$blocksize = $1; next} ($ext, '\
-'$logical, $physical, $expected, $length, $flags) = (/^\s*(\d+)\s+(\d+)'\
-'\s+(\d+)\s+(?:(\d+)\s+)?(\d+)\s+(.*)/) or next; $flags =~ '\
-'/(?:^|,)inline(?:,|$)/ and next; print $physical * $blocksize, "#", '\
+FILEFRAG_FILTER='if (/blocks of (\d+) bytes/) {$blocksize = $1; next} ($ext, '\
+'$logical, $physical, $length) = (/^\s*(\d+):\s+(\d+)..\s+\d+:'\
+'\s+(\d+)..\s+\d+:\s+(\d+):/) or next; print $physical * $blocksize, "#", '\
  '$length * $blocksize, "#", $logical * $blocksize, " "'
Oh, boy, who allowed that mess to pass review? Please format this in
a readable manner while you are changing it.
Yeah,  i was thinking to make it more readable while i had sent this out.^_^
Thanks for your comments.


        if (/blocks of (\d+) bytes/) {                  \
                $blocksize = $1;                        \
                next;                                   \



<Prev in Thread] Current Thread [Next in Thread>