xfs
[Top] [All Lists]

Re: [PATCH v3] xfstests: Btrfs: add test for large metadata blocks

To: Koen De Wit <koen.de.wit@xxxxxxxxxx>
Subject: Re: [PATCH v3] xfstests: Btrfs: add test for large metadata blocks
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 11 Feb 2014 09:04:00 +1100
Cc: xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1392068362-14049-1-git-send-email-koen.de.wit@xxxxxxxxxx>
References: <1392068362-14049-1-git-send-email-koen.de.wit@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Feb 10, 2014 at 10:39:22PM +0100, Koen De Wit wrote:
> Tests Btrfs filesystems with all possible metadata block sizes, by
> setting large extended attributes on files.
> 
> Signed-off-by: Koen De Wit <koen.de.wit@xxxxxxxxxx>
....
> +
> +_test_illegal_leafsize() {
> +        _scratch_mkfs -l $1 >>$seqres.full 2>&1
> +        [ $? -ne 0 ] || _fail "'$1' is an illegal value for the" \
> +                "leafsize option, mkfs should have failed."
> +}

You just re-implemented run_check....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>