xfs
[Top] [All Lists]

Re: [PATCH] xfs/033: add golden output for CRC enaled filesystems

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs/033: add golden output for CRC enaled filesystems
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 10 Feb 2014 21:55:33 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140210104426.GA9840@xxxxxxxxxxxxx>
References: <1391588590-6035-1-git-send-email-david@xxxxxxxxxxxxx> <20140207174950.GB31464@xxxxxxxxxxxxx> <20140210015105.GN13647@dastard> <20140210104426.GA9840@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Feb 10, 2014 at 02:44:26AM -0800, Christoph Hellwig wrote:
> On Mon, Feb 10, 2014 at 12:51:05PM +1100, Dave Chinner wrote:
> > I can't say I like adding that prefix to the mkfs varaibles. I'll
> > change this one to something less generic, but I'm going to ignore
> > the others right now because changing them involves modifying 30+
> > tests....
> 
> In that case let's keep the crc one without prefix for now.  But I think
> introducing very generic variables into the environment implicitly is
> a bad idea and will bite us long term.
> 
> Reluctantly:
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

I renamed it earlier this afternoon to "_fs_has_crc" so that code
that checks it makes sense when you read it:

        if [ $_fs_has_crc -eq 1 ]; then
                .....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>