| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs/033: add golden output for CRC enaled filesystems |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 10 Feb 2014 02:44:26 -0800 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140210015105.GN13647@dastard> |
| References: | <1391588590-6035-1-git-send-email-david@xxxxxxxxxxxxx> <20140207174950.GB31464@xxxxxxxxxxxxx> <20140210015105.GN13647@dastard> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Feb 10, 2014 at 12:51:05PM +1100, Dave Chinner wrote: > I can't say I like adding that prefix to the mkfs varaibles. I'll > change this one to something less generic, but I'm going to ignore > the others right now because changing them involves modifying 30+ > tests.... In that case let's keep the crc one without prefix for now. But I think introducing very generic variables into the environment implicitly is a bad idea and will bite us long term. Reluctantly: Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | potential use after free in xfs_iomap_write_allocate(), Dan Carpenter |
|---|---|
| Next by Date: | Re: [PATCH] xfs/189: noattr2 invalid for CRC enabled filesystems, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH] xfs/033: add golden output for CRC enaled filesystems, Dave Chinner |
| Next by Thread: | Re: [PATCH] xfs/033: add golden output for CRC enaled filesystems, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |