xfs
[Top] [All Lists]

Re: [PATCH 4/6] xfs: add helper for verifying checksums on xfs_bufs

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/6] xfs: add helper for verifying checksums on xfs_bufs
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 09 Feb 2014 21:35:55 -0600
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140210033323.GQ13647@dastard>
References: <52F83630.4020008@xxxxxxxxxx> <52F8399B.3050204@xxxxxxxxxxx> <20140210033323.GQ13647@dastard>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
On 2/9/14, 9:33 PM, Dave Chinner wrote:
> On Sun, Feb 09, 2014 at 08:29:47PM -0600, Eric Sandeen wrote:
>> Many/most callers of xfs_update_cksum() pass bp->b_addr and
>> BBTOB(bp->b_length) as the first 2 args.  Add a helper
>> which can just accept the bp and the crc offset, and work
>> it out on its own, for brevity.
> 
> The title of the patch is the same as the previous one - I think you
> forgot to "update" it?

Bah, yes.  Probably doesn't really even have to be 2 patches.

> Other than that, same comments as for the previous patch.

ok, thx for the reviews.  Agree that the defines make it better.

-Eric

> Cheers,
> 
> Dave.
> 

<Prev in Thread] Current Thread [Next in Thread>