xfs
[Top] [All Lists]

Re: [PATCH] xfs/033: add golden output for CRC enaled filesystems

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs/033: add golden output for CRC enaled filesystems
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 10 Feb 2014 12:51:05 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140207174950.GB31464@xxxxxxxxxxxxx>
References: <1391588590-6035-1-git-send-email-david@xxxxxxxxxxxxx> <20140207174950.GB31464@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Feb 07, 2014 at 09:49:50AM -0800, Christoph Hellwig wrote:
> On Wed, Feb 05, 2014 at 07:23:10PM +1100, Dave Chinner wrote:
> > diff --git a/common/filter b/common/filter
> > index 04d12c4..bb7fb33 100644
> > --- a/common/filter
> > +++ b/common/filter
> > @@ -152,6 +152,9 @@ _filter_mkfs()
> >      if (/^\s+=\s+sectsz=(\d+)\s+attr=(\d+)/) {
> >          print STDERR "sectsz=$1\nattr=$2\n";
> >      }
> > +    if (/^\s+=\s+crc=(\d)/) {
> > +        print STDERR "crc=$1\n";
> > +    }
> 
> I think this variable is named way to genericly.  And that probably
> applies to others as well.
> 
> I'd suggest at least xfs_feature_crc or similar.

I can't say I like adding that prefix to the mkfs varaibles. I'll
change this one to something less generic, but I'm going to ignore
the others right now because changing them involves modifying 30+
tests....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>