| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs/033: add golden output for CRC enaled filesystems |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 7 Feb 2014 09:49:50 -0800 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1391588590-6035-1-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1391588590-6035-1-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed, Feb 05, 2014 at 07:23:10PM +1100, Dave Chinner wrote:
> diff --git a/common/filter b/common/filter
> index 04d12c4..bb7fb33 100644
> --- a/common/filter
> +++ b/common/filter
> @@ -152,6 +152,9 @@ _filter_mkfs()
> if (/^\s+=\s+sectsz=(\d+)\s+attr=(\d+)/) {
> print STDERR "sectsz=$1\nattr=$2\n";
> }
> + if (/^\s+=\s+crc=(\d)/) {
> + print STDERR "crc=$1\n";
> + }
I think this variable is named way to genericly. And that probably
applies to others as well.
I'd suggest at least xfs_feature_crc or similar.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs/189: noattr2 invalid for CRC enabled filesystems, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] xfs/021: filter v5 filesystem metadata, Christoph Hellwig |
| Previous by Thread: | [PATCH] xfs/033: add golden output for CRC enaled filesystems, Dave Chinner |
| Next by Thread: | Re: [PATCH] xfs/033: add golden output for CRC enaled filesystems, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |