xfs
[Top] [All Lists]

Re: [PATCH v2 3/3] btrfs/035: add new clone overwrite regression test

To: David Disseldorp <ddiss@xxxxxxx>
Subject: Re: [PATCH v2 3/3] btrfs/035: add new clone overwrite regression test
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 7 Feb 2014 09:45:09 +1100
Cc: xfs@xxxxxxxxxxx, dsterba@xxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1391695154-2039-4-git-send-email-ddiss@xxxxxxx>
References: <1391695154-2039-1-git-send-email-ddiss@xxxxxxx> <1391695154-2039-4-git-send-email-ddiss@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Feb 06, 2014 at 02:59:14PM +0100, David Disseldorp wrote:
> This test uses the newly added cloner binary to dispatch full file and
> range specific clone (reflink) requests.

....
> +
> +echo -n "$src_str" > $SCRATCH_MNT/src || echo "failed to create src"

Not exactly what I intended.

If echo fails, it will output some kind of error message, and that
will cause the golden image mismatch.

Otherwise the test looks good.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>