xfs
[Top] [All Lists]

Re: [PATCH v3] Btrfs: add regression test for running snapshot and send

To: Wang Shilong <wangshilong1991@xxxxxxxxx>
Subject: Re: [PATCH v3] Btrfs: add regression test for running snapshot and send concurrently
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 7 Feb 2014 09:43:37 +1100
Cc: xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, jbacik@xxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1391703008-2322-1-git-send-email-wangshilong1991@xxxxxxxxx>
References: <1391703008-2322-1-git-send-email-wangshilong1991@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Feb 07, 2014 at 12:10:08AM +0800, Wang Shilong wrote:
> +$BTRFS_UTIL_PROG subvolume snapshot -r $SCRATCH_MNT \
> +     $SCRATCH_MNT/snap_1 >> $seqres.full 2>&1
> +
> +do_snapshots &
> +snapshots_pid=$!
> +
> +$BTRFS_UTIL_PROG send $SCRATCH_MNT/snap_1 > /dev/null 2>&1 || echo "btrfs 
> send failed"

Let's stop this anti-pattern before it takes hold.

If there's output from the send command it should be
filtered and captured in the golden image. Hence any deviation
caused by errors is automatically flagged as an error.

That's the whole point of using golden images for capturing errors -
you don't need to capture return values from binaries and it
guarantees that users are informed about failures through error
messages. IOWs:

$BTRFS_UTIL_PROG send $SCRATCH_MNT/snap_1 | _btrfs_send_filter

is what you should be doing here.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>