xfs
[Top] [All Lists]

Re: [PATCH 1/2] btrfs: add small program for clone testing

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] btrfs: add small program for clone testing
From: David Disseldorp <ddiss@xxxxxxx>
Date: Thu, 6 Feb 2014 11:03:48 +0100
Cc: xfs@xxxxxxxxxxx, dsterba@xxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140205230936.GI13997@dastard>
References: <1391599009-2402-1-git-send-email-ddiss@xxxxxxx> <1391599009-2402-2-git-send-email-ddiss@xxxxxxx> <20140205230936.GI13997@dastard>
Hi Dave,

On Thu, 6 Feb 2014 10:09:36 +1100, Dave Chinner wrote:

> On Wed, Feb 05, 2014 at 12:16:48PM +0100, David Disseldorp wrote:
> > The cloner program is capable of cloning files using the BTRFS_IOC_CLONE
> > and BTRFS_IOC_CLONE_RANGE ioctls.
> > 
> > Signed-off-by: David Disseldorp <ddiss@xxxxxxx>
> 
> Hi Dave - long time since I've seen your head pop up around here ;)

Indeed, it's been a while. Thanks for the review :)

> 
> A few comments below.
> 
> > +struct btrfs_ioctl_clone_range_args {
> > +   int64_t src_fd;
> > +   uint64_t src_offset;
> > +   uint64_t src_length;
> > +   uint64_t dest_offset;
> > +};
> > +
> > +#define BTRFS_IOCTL_MAGIC 0x94
> > +#define BTRFS_IOC_CLONE       _IOW(BTRFS_IOCTL_MAGIC, 9, int)
> > +#define BTRFS_IOC_CLONE_RANGE _IOW(BTRFS_IOCTL_MAGIC, 13, \
> > +                              struct btrfs_ioctl_clone_range_args)
> 
> Is there some published header file that these belong to? i.e.
> somewhere in the include/linux/uapi/ kernel directory? Normally the
> way to handle this sort of thing is by autoconf - if the header file
> exists, then we include it, otherwise we use the manual definitions.
> This just means that if the public api ever changes, we'll pick it
> up automatically in future...

I'd wanted to avoid the addition of another xfsqa prereq, but I guess
it'll work with the fall-back.
I'll add the autoconf logic to the next round, along with changes
addressing your other remarks.

Cheers, David

<Prev in Thread] Current Thread [Next in Thread>