xfs
[Top] [All Lists]

Re: [PATCH 1/2] btrfs: add small program for clone testing

To: David Disseldorp <ddiss@xxxxxxx>
Subject: Re: [PATCH 1/2] btrfs: add small program for clone testing
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 6 Feb 2014 10:09:36 +1100
Cc: xfs@xxxxxxxxxxx, dsterba@xxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1391599009-2402-2-git-send-email-ddiss@xxxxxxx>
References: <1391599009-2402-1-git-send-email-ddiss@xxxxxxx> <1391599009-2402-2-git-send-email-ddiss@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Feb 05, 2014 at 12:16:48PM +0100, David Disseldorp wrote:
> The cloner program is capable of cloning files using the BTRFS_IOC_CLONE
> and BTRFS_IOC_CLONE_RANGE ioctls.
> 
> Signed-off-by: David Disseldorp <ddiss@xxxxxxx>

Hi Dave - long time since I've seen your head pop up around here ;)

A few comments below.

> +struct btrfs_ioctl_clone_range_args {
> +     int64_t src_fd;
> +     uint64_t src_offset;
> +     uint64_t src_length;
> +     uint64_t dest_offset;
> +};
> +
> +#define BTRFS_IOCTL_MAGIC 0x94
> +#define BTRFS_IOC_CLONE       _IOW(BTRFS_IOCTL_MAGIC, 9, int)
> +#define BTRFS_IOC_CLONE_RANGE _IOW(BTRFS_IOCTL_MAGIC, 13, \
> +                                struct btrfs_ioctl_clone_range_args)

Is there some published header file that these belong to? i.e.
somewhere in the include/linux/uapi/ kernel directory? Normally the
way to handle this sort of thing is by autoconf - if the header file
exists, then we include it, otherwise we use the manual definitions.
This just means that if the public api ever changes, we'll pick it
up automatically in future...

> +int
> +main(int argc, char **argv)
> +{
> +     bool full_file = true;
> +     uint64_t src_off = 0;
> +     uint64_t dst_off = 0;
> +     uint64_t len = 0;
> +     char *src_file;
> +     int src_fd;
> +     char *dst_file;
> +     int dst_fd;
> +     int ret;
> +     int opt;
> +
> +     while ((opt = getopt(argc, argv, "s:d:l:")) != -1) {
> +             switch (opt) {
> +             case 's':
> +                     src_off = atoi(optarg);

atoi() only returns 32 bit numbers. You probably should use
strtoull() as the offset parameters are 64 bit.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>