Re: [PATCH] xfs: return -E2BIG if hit the maximum size limits of ACLs

xfs

Re: [PATCH] xfs: return -E2BIG if hit the maximum size limits of ACLs

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH] xfs: return -E2BIG if hit the maximum size limits of ACLs
From:	Jeff Liu <jeff.liu@xxxxxxxxxx>
Date:	Wed, 05 Feb 2014 17:38:50 +0800
Cc:	"xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20140204155156.GA3810@xxxxxxxxxxxxx>
References:	<52EBB032.8070306@xxxxxxxxxx> <20140204155156.GA3810@xxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0

On 02/04 2014 23:51 PM, Christoph Hellwig wrote:
> On Fri, Jan 31, 2014 at 10:16:18PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@xxxxxxxxxx>
>>
>> We should return -E2BIG rather than -EINVAL if hit the maximum size
>> limits of ACLS, as the former is consistent with VFS xattr syscalls.
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 
> You were already working on tests for this area, right?

Not yet, but I'll work out a separate generic test towards ACLs.

Thanks,
-Jeff

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH] xfs: return -E2BIG if hit the maximum size limits of ACLs, Christoph Hellwig Re: [PATCH] xfs: return -E2BIG if hit the maximum size limits of ACLs, Jeff Liu <=

Previous by Date:	[PATCH] xfs/189: noattr2 invalid for CRC enabled filesystems, Dave Chinner
Next by Date:	[PATCH 2/2] btrfs/035: add new clone overwrite regression test, David Disseldorp
Previous by Thread:	Re: [PATCH] xfs: return -E2BIG if hit the maximum size limits of ACLs, Christoph Hellwig
Next by Thread:	[PATCH 0/3] support appending AIO writes, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]