xfs
[Top] [All Lists]

Re: [PATCH 4/4] generic: inconsistent initial state for test_generic_pun

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/4] generic: inconsistent initial state for test_generic_punch
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 2 Feb 2014 23:40:05 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1391385365-12790-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1391385365-12790-1-git-send-email-david@xxxxxxxxxxxxx> <1391385365-12790-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Feb 03, 2014 at 10:56:05AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The first test may start with the file from the previous test, and
> that is in an unknown state. Hence always remove the test file
> before the first test so that it doesn't have extents inside the
> test range as it is supposed to be testing into a hole.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>