xfs
[Top] [All Lists]

[PATCH] xfs: return -E2BIG if hit the maximum size limits of ACLs

To: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Subject: [PATCH] xfs: return -E2BIG if hit the maximum size limits of ACLs
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Fri, 31 Jan 2014 22:16:18 +0800
Delivered-to: xfs@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
From: Jie Liu <jeff.liu@xxxxxxxxxx>

We should return -E2BIG rather than -EINVAL if hit the maximum size
limits of ACLS, as the former is consistent with VFS xattr syscalls.

Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
---
 fs/xfs/xfs_acl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_acl.c b/fs/xfs/xfs_acl.c
index 370eb3e..fd4e8ff 100644
--- a/fs/xfs/xfs_acl.c
+++ b/fs/xfs/xfs_acl.c
@@ -397,7 +397,7 @@ xfs_xattr_acl_set(struct dentry *dentry, const char *name,
        if (error)
                goto out_release;
 
-       error = -EINVAL;
+       error = -E2BIG;
        if (acl->a_count > XFS_ACL_MAX_ENTRIES(XFS_M(inode->i_sb)))
                goto out_release;
 
-- 
1.8.3.2

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] xfs: return -E2BIG if hit the maximum size limits of ACLs, Jeff Liu <=