| To: | "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx> |
|---|---|
| Subject: | [PATCH] xfs: improve xfs_bitmap_empty() |
| From: | Jeff Liu <jeff.liu@xxxxxxxxxx> |
| Date: | Fri, 31 Jan 2014 22:13:37 +0800 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
From: Jie Liu <jeff.liu@xxxxxxxxxx>
There is no need to travel through the whole bitmap items to verify
if the bitmap array is empty or not, instead, just return 0 directly
if an item is detected in bitmap array.
Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
---
fs/xfs/xfs_bit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/xfs/xfs_bit.c b/fs/xfs/xfs_bit.c
index 0e8885a..ae0acc2 100644
--- a/fs/xfs/xfs_bit.c
+++ b/fs/xfs/xfs_bit.c
@@ -32,13 +32,13 @@ int
xfs_bitmap_empty(uint *map, uint size)
{
uint i;
- uint ret = 0;
for (i = 0; i < size; i++) {
- ret |= map[i];
+ if (map[i])
+ return 0;
}
- return (ret == 0);
+ return 1;
}
/*
--
1.8.3.2
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Extended attributes limit in Linux, Jeff Liu |
|---|---|
| Next by Date: | [PATCH] xfs: return -E2BIG if hit the maximum size limits of ACLs, Jeff Liu |
| Previous by Thread: | Extended attributes limit in Linux, Sun_Blood |
| Next by Thread: | Re: [PATCH] xfs: improve xfs_bitmap_empty(), Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |