xfs
[Top] [All Lists]

Re: [RFC] A draft for making ext4 support project quota

To: Andreas Dilger <adilger@xxxxxxxxx>
Subject: Re: [RFC] A draft for making ext4 support project quota
From: Jan Kara <jack@xxxxxxx>
Date: Thu, 30 Jan 2014 20:42:24 +0100
Cc: Zheng Liu <gnehzuil.liu@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, linux-ext4 <linux-ext4@xxxxxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Theodore Ts'o <tytso@xxxxxxx>, Dmitry Monakhov <dmonakhov@xxxxxxxxxx>, Li Xi <pkuelelixi@xxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Ben Myers <bpm@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <A5AD0D66-C4F5-4177-9F87-E3BC59B348B8@xxxxxxxxx>
References: <20140128064248.GA8653@xxxxxxxxx> <20140128143514.GB13676@xxxxxxxxxxxxx> <20140129034824.GA12757@xxxxxxxxx> <A5AD0D66-C4F5-4177-9F87-E3BC59B348B8@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu 30-01-14 11:57:10, Andreas Dilger wrote:
> On Jan 28, 2014, at 8:48 PM, Zheng Liu <gnehzuil.liu@xxxxxxxxx> wrote:
> > On Tue, Jan 28, 2014 at 03:35:14PM +0100, Jan Kara wrote:
> >> On Tue 28-01-14 14:42:49, Zheng Liu wrote:
> >>> For project quota, the key issue is how to handle link(2)/rename(2).  We
> >>> summarize the behaviour in xfs as following.
> >>> 
> >>> *Note*
> >>> + unaccounted dir
> >>> x accounted dir
> >>> 
> >>> link(2)
> >>> -------
> >>>           +               x
> >>> +         ok              error (EXDEV)
> >>> x         ok              error (EXDEV)
> 
> Presumably this accounted-to-accounted link() is only an error if
> it is between directories of two different projects?
  Yes, I understand it that way.

> >>> rename(2)
> >>> ---------
> >>>           +               x
> >>> +         ok              ok
> >>> x         wrong           ok
> >> 
> >>  So moving unaccounted file/dir into an accounted dir would be OK? How is
> >> that?
> > 
> > Actually xfs will return EXDEV error when we try to move unaccounted
> > file/dir into an accounted dir.  Then userspace tools (e.g. mv(1)) will
> > use create(2)/read(2)/write(2) syscalls to create these files/dirs from
> > scratch, and get the same id from their parent.
> 
> Why wouldn't renaming an unaccounted file into an accounted directory
> just be implemented by doing the equivalent of chown() to change the
> project ID and setting the quota?  That could avoid a HUGE amount of
> data copying for large files.
  Well, the trouble is not so much with a file but with a directory. If you
move an unaccounted directory in an accounted dir, you would have to
recursively go through it and account each file. That isn't possible to do
reliably from the kernel... And allowing files but disallowing dirs seems
inconsistent so I'm in favor of a simple API.

                                                                Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR

<Prev in Thread] Current Thread [Next in Thread>