Re: [PATCH] xfs: ensure correct timestamp updates from truncate

xfs

Re: [PATCH] xfs: ensure correct timestamp updates from truncate

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH] xfs: ensure correct timestamp updates from truncate
From:	Ben Myers <bpm@xxxxxxx>
Date:	Thu, 30 Jan 2014 09:47:01 -0600
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20140130080652.GA23758@xxxxxxxxxxxxx>
References:	<20140110122700.GA12624@localhost> <52CFF402.5080409@xxxxxxxxxx> <20140110133306.GA22918@xxxxxxxxxxxxx> <52CFFD1C.7050005@xxxxxxxxxx> <20140111111045.GA29380@xxxxxxxxxxxxx> <52E8FE81.7040402@xxxxxxxxxx> <20140130080652.GA23758@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

On Thu, Jan 30, 2014 at 12:06:52AM -0800, Christoph Hellwig wrote:
> The VFS doesn't set the proper ATTR_CTIME and ATTR_MTIME values for truncate,
> so filesystems have to manually add them.  The introduction of
> xfs_setattr_time accidentally broke this special case an caused a
> regression in generic/313.  Fix this by removing the local mask variable
> in xfs_setattr_size so that we only have a single place to keep the
> attribute information.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>

That is v3.13-rc2-14-gc91c46c, so I believe we'll want to Cc: stable on this
one.  Correct?

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[xfs] c91c46c12: xfstests generic/313 regression, fengguang . wu Re: [xfs] c91c46c12: xfstests generic/313 regression, Jeff Liu Re: [xfs] c91c46c12: xfstests generic/313 regression, Christoph Hellwig Re: [xfs] c91c46c12: xfstests generic/313 regression, Jeff Liu Re: [xfs] c91c46c12: xfstests generic/313 regression, Christoph Hellwig Re: [xfs] c91c46c12: xfstests generic/313 regression, Brian Foster Re: [xfs] c91c46c12: xfstests generic/313 regression, Christoph Hellwig [PATCH] xfs: ensure correct timestamp updates from truncate, Christoph Hellwig Re: [PATCH] xfs: ensure correct timestamp updates from truncate, Jeff Liu Re: [PATCH] xfs: ensure correct timestamp updates from truncate, Brian Foster Re: [PATCH] xfs: ensure correct timestamp updates from truncate, Ben Myers <=

Previous by Date:	Re: Question regarding XFS on LVM over hardware RAID., C. Morgan Hamill
Next by Date:	Re: [RFC] A draft for making ext4 support project quota, Andreas Dilger
Previous by Thread:	Re: [PATCH] xfs: ensure correct timestamp updates from truncate, Brian Foster
Next by Thread:	Re: projid32bit=1 default in xfsprogs-3.2.0, Rich Johnston
Indexes:	[Date] [Thread] [Top] [All Lists]