xfs
[Top] [All Lists]

Re: [PATCH] xfs: ensure correct timestamp updates from truncate

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH] xfs: ensure correct timestamp updates from truncate
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Thu, 30 Jan 2014 08:57:37 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140130080652.GA23758@xxxxxxxxxxxxx>
References: <20140110122700.GA12624@localhost> <52CFF402.5080409@xxxxxxxxxx> <20140110133306.GA22918@xxxxxxxxxxxxx> <52CFFD1C.7050005@xxxxxxxxxx> <20140111111045.GA29380@xxxxxxxxxxxxx> <52E8FE81.7040402@xxxxxxxxxx> <20140130080652.GA23758@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
On 01/30/2014 03:06 AM, Christoph Hellwig wrote:
> The VFS doesn't set the proper ATTR_CTIME and ATTR_MTIME values for truncate,
> so filesystems have to manually add them.  The introduction of
> xfs_setattr_time accidentally broke this special case an caused a
> regression in generic/313.  Fix this by removing the local mask variable
> in xfs_setattr_size so that we only have a single place to keep the
> attribute information.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> 

Thanks Christoph!

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index 0ce1d75..ce966c5 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -714,7 +714,6 @@ xfs_setattr_size(
>  {
>       struct xfs_mount        *mp = ip->i_mount;
>       struct inode            *inode = VFS_I(ip);
> -     int                     mask = iattr->ia_valid;
>       xfs_off_t               oldsize, newsize;
>       struct xfs_trans        *tp;
>       int                     error;
> @@ -735,8 +734,8 @@ xfs_setattr_size(
>  
>       ASSERT(xfs_isilocked(ip, XFS_IOLOCK_EXCL));
>       ASSERT(S_ISREG(ip->i_d.di_mode));
> -     ASSERT((mask & (ATTR_UID|ATTR_GID|ATTR_ATIME|ATTR_ATIME_SET|
> -                     ATTR_MTIME_SET|ATTR_KILL_PRIV|ATTR_TIMES_SET)) == 0);
> +     ASSERT((iattr->ia_valid & (ATTR_UID|ATTR_GID|ATTR_ATIME|ATTR_ATIME_SET|
> +             ATTR_MTIME_SET|ATTR_KILL_PRIV|ATTR_TIMES_SET)) == 0);
>  
>       oldsize = inode->i_size;
>       newsize = iattr->ia_size;
> @@ -745,7 +744,7 @@ xfs_setattr_size(
>        * Short circuit the truncate case for zero length files.
>        */
>       if (newsize == 0 && oldsize == 0 && ip->i_d.di_nextents == 0) {
> -             if (!(mask & (ATTR_CTIME|ATTR_MTIME)))
> +             if (!(iattr->ia_valid & (ATTR_CTIME|ATTR_MTIME)))
>                       return 0;
>  
>               /*
> @@ -833,10 +832,11 @@ xfs_setattr_size(
>        * these flags set.  For all other operations the VFS set these flags
>        * explicitly if it wants a timestamp update.
>        */
> -     if (newsize != oldsize && (!(mask & (ATTR_CTIME | ATTR_MTIME)))) {
> +     if (newsize != oldsize &&
> +         !(iattr->ia_valid & (ATTR_CTIME | ATTR_MTIME))) {
>               iattr->ia_ctime = iattr->ia_mtime =
>                       current_fs_time(inode->i_sb);
> -             mask |= ATTR_CTIME | ATTR_MTIME;
> +             iattr->ia_valid |= ATTR_CTIME | ATTR_MTIME;
>       }
>  
>       /*
> @@ -872,9 +872,9 @@ xfs_setattr_size(
>               xfs_inode_clear_eofblocks_tag(ip);
>       }
>  
> -     if (mask & ATTR_MODE)
> +     if (iattr->ia_valid & ATTR_MODE)
>               xfs_setattr_mode(ip, iattr);
> -     if (mask & (ATTR_ATIME|ATTR_CTIME|ATTR_MTIME))
> +     if (iattr->ia_valid & (ATTR_ATIME|ATTR_CTIME|ATTR_MTIME))
>               xfs_setattr_time(ip, iattr);
>  
>       xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>