xfs
[Top] [All Lists]

Re: [PATCH] xfs: ensure correct timestamp updates from truncate

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: ensure correct timestamp updates from truncate
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Thu, 30 Jan 2014 16:33:05 +0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140130080652.GA23758@xxxxxxxxxxxxx>
References: <20140110122700.GA12624@localhost> <52CFF402.5080409@xxxxxxxxxx> <20140110133306.GA22918@xxxxxxxxxxxxx> <52CFFD1C.7050005@xxxxxxxxxx> <20140111111045.GA29380@xxxxxxxxxxxxx> <52E8FE81.7040402@xxxxxxxxxx> <20140130080652.GA23758@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 01/30 2014 16:06 PM, Christoph Hellwig wrote:
> The VFS doesn't set the proper ATTR_CTIME and ATTR_MTIME values for truncate,
> so filesystems have to manually add them.  The introduction of
> xfs_setattr_time accidentally broke this special case an caused a
> regression in generic/313.  Fix this by removing the local mask variable
> in xfs_setattr_size so that we only have a single place to keep the
> attribute information.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>

Reviewed-by: Jie Liu <jeff.liu@xxxxxxxxxx>

Thanks,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>