xfs
[Top] [All Lists]

Re: [NOISE] merge window blues, XFS broken

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [NOISE] merge window blues, XFS broken
From: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
Date: Wed, 29 Jan 2014 17:31:00 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=Oy+AVx5ohs/8nYveSVYLIn6+E0o1nZznrIaSD/johzc=; b=GcSqEjWa12+XKE/4d1IJpvHzO1efKniGjQG5UamFLSHwnaENJ0RrxGLcrqLg/a0XNI 3364qayKHpwMA7mZZcmm5Yz9Zl6+zUBI0xKvnW1O14JwOH2BKS6agCIlLCP38OnCHnK4 d+7Q9U1cXGVJbzwC1jpdj4l1IvJBuBEQ0Y7WfMq/HxEftS82JEyIfEFcKmiYB9IZAtnn /JdJpyhuUNKxsoWFRwRx7RDTXOgOw/xoaKjruJohjUBFaA1B4y3iayKmeuOJqH7I0v+p AiOfCk0zy1LpLVK740mcfF6ceNrXszsZQ23kurR6qo1QAFsqX/1mq+0y8uQ/balW73HP YCHg==
In-reply-to: <20140128095559.GJ2212@dastard>
References: <52E56386.5040802@xxxxxxxxx> <20140127015614.GD2212@dastard> <52E62ADA.2040800@xxxxxxxxx> <20140127233039.GF2212@dastard> <52E768CF.5040908@xxxxxxxxx> <20140128095559.GJ2212@dastard>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
On 01/28/2014 04:55 AM, Dave Chinner wrote:
> Ok, so xfs_inode_item_format+0x4a is inside the very first call to
> preapre the ilf structure. That tells us that the initial
> xfs_log_vec/xfs_log_iovec array are resulting in an unaligned
> buffer.
> 
> Can you try the patch below, Michael?
> 
> Cheers,
> 
> Dave.

To the best of my knowledge, it works fine.  It was subjected to some
of the xfstests xfs/* and generic/* series along with some of the
"log" group.  In addition, it was run through fs_mark and a homebrew
benchmark idea of running a ( make clean; make ) loop for the kernel
while two fsx processes were running.  This was for default (4k, 
internal logdev) v5-superblock XFS filesystems. v4-superblock XFS 
went through similar testing, to a lesser degree.

I did not know about a message like "log buf needs to be larger than
stripe size" on tests that require v2 logs.  [xfs/087 might be one of
those tests.]  This was also the case for the test-patch that padded
the structs directly, and this might be an old message.

At the very least, I'm keeping this patch.  Your approach to the
solution looks cool.  Basically, you're stating that you can have
either xfs_log_vec or xfs_log_iovec in there, and no matter what
their size, they get aligned in the log, correct?

Thanks!

Michael


<Prev in Thread] Current Thread [Next in Thread>