xfs
[Top] [All Lists]

Re: [PATCH] xfstests: avoid ext4/306 failures caused by incompatible mou

To: <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: avoid ext4/306 failures caused by incompatible mount options
From: Kodiak Furr <boxerapp@xxxxxxx>
Date: Wed, 29 Jan 2014 15:48:32 -0600
Cc: <xfs@xxxxxxxxxxx>, Eric Whitney <enwlinux@xxxxxxxxx>, <linux-ext4@xxxxxxxxxxxxxxx>, Theodore Ts'o <tytso@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mx.aol.com; s=20121107; t=1391032110; bh=ZrHnsmmIwF8jU87Z10Bgiq0OjUD6jP1AJJRhyydeHB4=; h=From:To:Subject:Message-ID:Date:MIME-Version:Content-Type; b=HmPix5VVPYZAQJJs3vVDs5TvZU4kvVE6201EBEqYpSgcHVzRRjcU+bzK6bnCEr1Fi MWLw1ObTlL3qQv7fDOsKPoajsYfzjlut6tiBMywrEQKo5hj8KuIUeO96M0H9c9M5PY UUAyEtb7iPymvtCstK+lnsZG4gKNNz/HG2Nf/eWk=
In-reply-to: <52E9761F.7070903@xxxxxxxxxx>
References: <20140129213838.GF30419@xxxxxxxxx> <52E9761F.7070903@xxxxxxxxxx>
Kodiak Furr liked your message with Boxer.


On January 29, 2014 at 3:43:59 PM CST, Eric Sandeen wrote:
On 1/29/14, 3:38 PM, Theodore Ts'o wrote:
> On Wed, Jan 29, 2014 at 03:45:02PM -0500, Eric Whitney wrote:
>> ext4/306 will fail when mounting the ext3 file system it creates if an
>> ext3-incompatible mount option is applied by _scratch_mount. This can
>> happen if EXT_MOUNT_OPTIONS is defined appropriately in the test
>> environment. For example, the block_validity option is commonly used
>> to enhance ext4 testing, and it is not supported by ext3. Fix this by
>> not including any mount options defined by the test environment.
>
> I'm not sure I understand why the test is insisting that the file
> system be mounted using ext3. If the file system is created without
> the extents flag, all of the files will be created using indirect
> blocks, and fundamentally what this test is getting at is that after
> we grow the file system using resize2fs, the new blocks are available
> to be allocated and attached to an indirect block file.
>
> We can do this by using ext4; I'm not sure why this test is trying to
> use ext3 to set up the test flie system. It might be better to get
> rid of the requirement to create the file system using ext3, since it
> will make the test runnable even if the ext3 file system hasn't been
> configured into the system and CONFIG_EXT23_AS_EXT4 is not enabled.
>
> IIRC, Eric Sandeen wrote this test --- Eric, am I missing some reason
> why it was necessary to use ext3 here?

Nope. Tomayto, tomahto - I think the original report had trouble with
an ext3 filesystem, so that's how I wrote the testcase.

It could be fixed either way, I think.

-Eric

>
> - Ted
>

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
<Prev in Thread] Current Thread [Next in Thread>