[Top] [All Lists]

Re: [PATCH] xfstests: avoid ext4/306 failures caused by incompatible mou

To: Eric Whitney <enwlinux@xxxxxxxxx>
Subject: Re: [PATCH] xfstests: avoid ext4/306 failures caused by incompatible mount options
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Wed, 29 Jan 2014 16:38:38 -0500
Cc: xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, esandeen@xxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=thunk.org; s=mail; t=1391031518; bh=4l6tCZapevrbpHvlgtjQCW9rf0bjMNDo9R2XYAqvzfY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1SOMy8NyHJKVPcAhDmXMjHvuHMOVdU+nV1Eumdjw0D/NROqT6XngzUI0kI4MTOinK eN39tTMWfIuTN7NxQKaouoxdWfV6e2MROvHZYcB0pWxYGBbfPBTZ5KZpDk0G5G4eGS KecvZDpe/D5l3ZIV0VnMKlCXLThZhcVZiDFhhX/M=
In-reply-to: <20140129204502.GC2165@wallace>
References: <20140129204502.GC2165@wallace>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jan 29, 2014 at 03:45:02PM -0500, Eric Whitney wrote:
> ext4/306 will fail when mounting the ext3 file system it creates if an
> ext3-incompatible mount option is applied by _scratch_mount.  This can
> happen if EXT_MOUNT_OPTIONS is defined appropriately in the test
> environment.  For example, the block_validity option is commonly used
> to enhance ext4 testing, and it is not supported by ext3.  Fix this by
> not including any mount options defined by the test environment.

I'm not sure I understand why the test is insisting that the file
system be mounted using ext3.  If the file system is created without
the extents flag, all of the files will be created using indirect
blocks, and fundamentally what this test is getting at is that after
we grow the file system using resize2fs, the new blocks are available
to be allocated and attached to an indirect block file.

We can do this by using ext4; I'm not sure why this test is trying to
use ext3 to set up the test flie system.  It might be better to get
rid of the requirement to create the file system using ext3, since it
will make the test runnable even if the ext3 file system hasn't been
configured into the system and CONFIG_EXT23_AS_EXT4 is not enabled.

IIRC, Eric Sandeen wrote this test --- Eric, am I missing some reason
why it was necessary to use ext3 here?

                                        - Ted

<Prev in Thread] Current Thread [Next in Thread>