| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH] xfstests: avoid ext4/306 failures caused by incompatible mount options |
| From: | Eric Whitney <enwlinux@xxxxxxxxx> |
| Date: | Wed, 29 Jan 2014 15:45:02 -0500 |
| Cc: | linux-ext4@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=Csf+AJgJA4L/kHop2bscmesVyc0yEih5ggpiRmjYcyA=; b=xYH0i4gydqWKutTVFtsKd8ftpl8ETPqt8YqNCNOktPwt3eRawbjS1tGjOSskdMaFhf H0d6ZI1iAIJYtSsX3xfFta7YSuUTLHYxceLx4q8XvmGQH1ogWP1v+FC+LOEU+7AR6pik IPOkKSHwXTSmgmL2buAF6qM4MwdhLPZ61A3miCuLAQgqiY9voss6Ay0NjDX1Phzz6+ou 0UDpRnr9sAoSqQm+L01REZxIHIvYqOhfALHXf+sr+b936RmIiIQDQnNix/WbIZZS/yu2 yYC1njTL09ShDDyPoG8/qpUqI9N9Tv0vUoXQzmiyzADUcCmbG57sr4q6xtqv5T1tvdXQ BoJA== |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
ext4/306 will fail when mounting the ext3 file system it creates if an ext3-incompatible mount option is applied by _scratch_mount. This can happen if EXT_MOUNT_OPTIONS is defined appropriately in the test environment. For example, the block_validity option is commonly used to enhance ext4 testing, and it is not supported by ext3. Fix this by not including any mount options defined by the test environment. Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx> --- tests/ext4/306 | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/ext4/306 b/tests/ext4/306 index 398c4c0..e59c8ed 100755 --- a/tests/ext4/306 +++ b/tests/ext4/306 @@ -52,9 +52,10 @@ grep -q ext3 /proc/filesystems || _notrun "This test requires ext3 support" rm -f $seqres.full -# Make a small ext3 fs, (extents disabled) & mount it +# Make a small ext3 fs, (extents disabled) yes | mkfs.ext3 $SCRATCH_DEV 512m >> $seqres.full 2>&1 -_scratch_mount -t ext3 || _fail "couldn't mount fs as ext3" +# Mount it without _scratch_mount to avoid any ext3-incompatible mount options +_mount -t ext3 $SCRATCH_DEV $SCRATCH_MNT || _fail "couldn't mount fs as ext3" # Create a small non-extent-based file echo "Create 1m testfile1" $XFS_IO_PROG -f $SCRATCH_MNT/testfile1 -c "pwrite 0 1m" | _filter_xfs_io -- 1.8.3.2 |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [ANNOUNCE] xfstests updated to 197f773, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH] xfstests: avoid ext4/306 failures caused by incompatible mount options, Theodore Ts'o |
| Previous by Thread: | Re: FAST paper on ffsck, Darrick J. Wong |
| Next by Thread: | Re: [PATCH] xfstests: avoid ext4/306 failures caused by incompatible mount options, Theodore Ts'o |
| Indexes: | [Date] [Thread] [Top] [All Lists] |